unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Sergey Trofimov <sarg@sarg.org.ru>
Cc: 62310@debbugs.gnu.org
Subject: [bug#62310] [PATCH 0/4] gnu: fdroidcl: Update to 0.7.0.
Date: Mon, 20 Mar 2023 21:58:33 -0400	[thread overview]
Message-ID: <87wn3a27cm.fsf_-_@gmail.com> (raw)
In-Reply-To: <20230320225133.24860-4-sarg@sarg.org.ru> (Sergey Trofimov's message of "Mon, 20 Mar 2023 23:51:33 +0100")

Hi!

Sergey Trofimov <sarg@sarg.org.ru> writes:

> * gnu/packages/android.scm (fdroidcl): Update to 0.7.0.
> ---
>  gnu/packages/android.scm | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/gnu/packages/android.scm b/gnu/packages/android.scm
> index 881b75d763..9d67dca0cd 100644
> --- a/gnu/packages/android.scm
> +++ b/gnu/packages/android.scm
> @@ -1195,25 +1195,25 @@ (define-public fdroidserver
>  (define-public fdroidcl
>    (package
>      (name "fdroidcl")
> -    (version "0.5.0")
> +    (version "0.7.0")
>      (source (origin
>                (method git-fetch)
>                (uri (git-reference
> -                     (url "https://github.com/mvdan/fdroidcl")
> -                     (commit (string-append "v" version))))
> +                    (url "https://github.com/mvdan/fdroidcl")
> +                    (commit (string-append "v" version))))
>                (file-name (git-file-name name version))
>                (sha256
> -               (base32 "1rxcdyy2j34z0ql9d62w7ivsch9xihjnpb1z9kgy9q46vl8zhhy0"))))
> +               (base32
> +                "1s3fszlyyab9gbdrg52zcbafsb1mgb770skg7b3gj7f3pzfnra5n"))))
>      (build-system go-build-system)
>      (arguments
>       `(#:import-path "mvdan.cc/fdroidcl"
> -       #:tests? #f  ; TODO: Inputs missing.
> +       #:tests? #f ;requires internet access

Perhaps, ";tests require internet access"

>         #:install-source? #f))
> -    (inputs
> -     (list go-github-com-kr-pretty))
> -    ;(native-inputs
> -    ; `(("go-github-com-rogpeppe-go-internal-testscript"
> -    ;    ,go-github-com-rogpeppe-go-internal-testscript)))
> +    (inputs (list go-github-com-kr-pretty go-github-com-schollz-progressbar-v3))
> +    ;; these are for tests, but the tests are disabled
> +    ;; (native-inputs
> +    ;; (list go-github-com-rogpeppe-go-internal go-gopkg-in-check-v1))

I think I'd remove the native-inputs completely instead of keeping dead
code around.

Thanks for the contribution!  I look forward to v2.

-- 
Maxim




  reply	other threads:[~2023-03-21  1:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-20 22:47 [bug#62310] [PATCH 0/4] gnu: fdroidcl: Update to 0.7.0 Sergey Trofimov
2023-03-20 22:51 ` [bug#62310] [PATCH 1/4] gnu: Add go-github-com-schollz-progressbar-v3 Sergey Trofimov
2023-03-20 22:51   ` [bug#62310] [PATCH 2/4] gnu: Add go-github-com-mitchellh-colorstring Sergey Trofimov
2023-03-21  1:47     ` [bug#62310] [PATCH 0/4] gnu: fdroidcl: Update to 0.7.0 Maxim Cournoyer
2023-03-20 22:51   ` [bug#62310] [PATCH 3/4] gnu: Add go-github-com-k0kubun-go-ansi Sergey Trofimov
2023-03-21  1:55     ` [bug#62310] [PATCH 0/4] gnu: fdroidcl: Update to 0.7.0 Maxim Cournoyer
2023-03-20 22:51   ` [bug#62310] [PATCH] " Sergey Trofimov
2023-03-21  1:58     ` Maxim Cournoyer [this message]
2023-03-21  1:43   ` [bug#62310] [PATCH 0/4] " Maxim Cournoyer
2023-03-21  1:46   ` Maxim Cournoyer
2023-03-21  8:04 ` [bug#62310] [PATCH v2 " Sergey Trofimov
2023-03-21  8:15   ` [bug#62310] [PATCH v2 1/4] gnu: Add go-github-com-mitchellh-colorstring Sergey Trofimov
2023-03-21  8:16   ` [bug#62310] [PATCH v2 2/4] gnu: Add go-github-com-schollz-progressbar-v3 Sergey Trofimov
2023-03-21  8:16   ` [bug#62310] [PATCH v2 3/4] gnu: fdroidcl: Update to 0.7.0 Sergey Trofimov
2023-03-21  8:16   ` [bug#62310] [PATCH v2 4/4] guix: Put check-synopsis-style to the local checkers list Sergey Trofimov
2023-03-21 18:09   ` bug#62310: [PATCH v2 0/4] gnu: fdroidcl: Update to 0.7.0 Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wn3a27cm.fsf_-_@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=62310@debbugs.gnu.org \
    --cc=sarg@sarg.org.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).