unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Sergey Trofimov <sarg@sarg.org.ru>
Cc: 62310@debbugs.gnu.org
Subject: [bug#62310] [PATCH 0/4] gnu: fdroidcl: Update to 0.7.0.
Date: Mon, 20 Mar 2023 21:46:55 -0400	[thread overview]
Message-ID: <87a6063mgg.fsf_-_@gmail.com> (raw)
In-Reply-To: <20230320225133.24860-1-sarg@sarg.org.ru> (Sergey Trofimov's message of "Mon, 20 Mar 2023 23:51:30 +0100")

Hi,

Sorry, I forgot a couple comments;

Sergey Trofimov <sarg@sarg.org.ru> writes:

> * gnu/packages/golang.scm (go-github-com-schollz-progressbar-v3):
> New variable.

Nitpick; but it'd be more conventional to break the line this:

* gnu/packages/golang.scm
(go-github-com-schollz-progressbar-v3): New variable.

The essence of it is explained in info '(standards) Style of Change
Logs'.

> ---
>  gnu/packages/golang.scm | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>
> diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
> index c75fdb4a31..e9187a14e9 100644
> --- a/gnu/packages/golang.scm
> +++ b/gnu/packages/golang.scm
> @@ -11304,6 +11304,38 @@ (define-public go-sigs-k8s-io-yaml
>  @url{https://github.com/ghodss/yaml,ghodss/yaml}.")
>      (license (list license:expat license:bsd-3))))
>  
> +(define-public go-github-com-schollz-progressbar-v3
> +  (package
> +    (name "go-github-com-schollz-progressbar-v3")
> +    (version "3.13.1")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/schollz/progressbar")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "1hjahr5r52i7w6iyvl3rpzr46iignhfdh4694fl7m2b4gkaw9gd6"))))
> +    (build-system go-build-system)
> +    (arguments
> +     '(#:import-path "github.com/schollz/progressbar/v3"
> +       #:tests? #f))
> +    (propagated-inputs (list go-golang-org-x-term
> +                             go-github-com-stretchr-testify
> +                             go-github-com-mitchellh-colorstring
> +                             go-github-com-mattn-go-runewidth
> +                             go-github-com-mattn-go-isatty
> +                             go-github-com-k0kubun-go-ansi
> +                             go-github-com-davecgh-go-spew))
> +    (home-page "https://github.com/schollz/progressbar")
> +    (synopsis "Simple cross-platform progress bar.")

synopsis should not end with a trailing period (they are not complete
sentence).  I think 'guix lint' should complain about that.

-- 
Thanks,
Maxim




  parent reply	other threads:[~2023-03-21  1:48 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-20 22:47 [bug#62310] [PATCH 0/4] gnu: fdroidcl: Update to 0.7.0 Sergey Trofimov
2023-03-20 22:51 ` [bug#62310] [PATCH 1/4] gnu: Add go-github-com-schollz-progressbar-v3 Sergey Trofimov
2023-03-20 22:51   ` [bug#62310] [PATCH 2/4] gnu: Add go-github-com-mitchellh-colorstring Sergey Trofimov
2023-03-21  1:47     ` [bug#62310] [PATCH 0/4] gnu: fdroidcl: Update to 0.7.0 Maxim Cournoyer
2023-03-20 22:51   ` [bug#62310] [PATCH 3/4] gnu: Add go-github-com-k0kubun-go-ansi Sergey Trofimov
2023-03-21  1:55     ` [bug#62310] [PATCH 0/4] gnu: fdroidcl: Update to 0.7.0 Maxim Cournoyer
2023-03-20 22:51   ` [bug#62310] [PATCH] " Sergey Trofimov
2023-03-21  1:58     ` [bug#62310] [PATCH 0/4] " Maxim Cournoyer
2023-03-21  1:43   ` Maxim Cournoyer
2023-03-21  1:46   ` Maxim Cournoyer [this message]
2023-03-21  8:04 ` [bug#62310] [PATCH v2 " Sergey Trofimov
2023-03-21  8:15   ` [bug#62310] [PATCH v2 1/4] gnu: Add go-github-com-mitchellh-colorstring Sergey Trofimov
2023-03-21  8:16   ` [bug#62310] [PATCH v2 2/4] gnu: Add go-github-com-schollz-progressbar-v3 Sergey Trofimov
2023-03-21  8:16   ` [bug#62310] [PATCH v2 3/4] gnu: fdroidcl: Update to 0.7.0 Sergey Trofimov
2023-03-21  8:16   ` [bug#62310] [PATCH v2 4/4] guix: Put check-synopsis-style to the local checkers list Sergey Trofimov
2023-03-21 18:09   ` bug#62310: [PATCH v2 0/4] gnu: fdroidcl: Update to 0.7.0 Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6063mgg.fsf_-_@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=62310@debbugs.gnu.org \
    --cc=sarg@sarg.org.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).