From: Kei Kebreau <kei@openmailbox.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 26437@debbugs.gnu.org
Subject: bug#26437: [PATCH] gnu: Add emacspeak.
Date: Tue, 11 Apr 2017 11:22:21 -0400 [thread overview]
Message-ID: <87vaqb2clu.fsf@openmailbox.org> (raw)
In-Reply-To: <87r30zruns.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 11 Apr 2017 14:33:11 +0200")
[-- Attachment #1: Type: text/plain, Size: 1249 bytes --]
ludo@gnu.org (Ludovic Courtès) writes:
> Hello Kei,
>
> Kei Kebreau <kei@openmailbox.org> skribis:
>
>> * gnu/packages/emacs.scm (emacspeak): New variable.
>
> [...]
>
>> + (add-after 'install-espeak-server 'wrap-program
>> + (lambda* (#:key inputs outputs #:allow-other-keys)
>> + (let* ((out (assoc-ref outputs "out"))
>> + (emacspeak (string-append out "/bin/emacspeak"))
>> + (espeak (string-append (assoc-ref inputs "espeak")
>> + "/bin/espeak")))
>> + (wrap-program emacspeak
>> + `("DTK_PROGRAM" ":" prefix (,espeak)))))))
>
> Please return #t here. Could you also add a note about what
> ‘DTK_PROGRAM’ is and what component honors it?
>
>> + (home-page "http://emacspeak.sourceforge.net")
>> + (synopsis "Audio desktop interface for Emacs")
>> + (description
>> + "Emacspeak is an Emacs subsystem that provides complete speech
>> access.")
>
> Could you expound a bit, probably borrowing bits from their home page?
>
> Otherwise LGTM. OK with these changes!
>
> Thanks,
> Ludo’.
Pushed to master with the required changes. Thanks for the review.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2017-04-11 15:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 22:41 bug#26437: [PATCH] gnu: Add emacspeak Kei Kebreau
2017-04-11 12:33 ` Ludovic Courtès
2017-04-11 15:22 ` Kei Kebreau [this message]
2017-04-11 15:25 ` Kei Kebreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vaqb2clu.fsf@openmailbox.org \
--to=kei@openmailbox.org \
--cc=26437@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).