From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36140) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cxxdJ-00054S-IP for guix-patches@gnu.org; Tue, 11 Apr 2017 11:23:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cxxdG-0007r4-Df for guix-patches@gnu.org; Tue, 11 Apr 2017 11:23:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:44930) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cxxdG-0007qq-A0 for guix-patches@gnu.org; Tue, 11 Apr 2017 11:23:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cxxdG-0002Gv-4B for guix-patches@gnu.org; Tue, 11 Apr 2017 11:23:02 -0400 Subject: bug#26437: [PATCH] gnu: Add emacspeak. Resent-Message-ID: From: Kei Kebreau References: <20170410224124.28803-1-kei@openmailbox.org> <87r30zruns.fsf@gnu.org> Date: Tue, 11 Apr 2017 11:22:21 -0400 In-Reply-To: <87r30zruns.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 11 Apr 2017 14:33:11 +0200") Message-ID: <87vaqb2clu.fsf@openmailbox.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 26437@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Hello Kei, > > Kei Kebreau skribis: > >> * gnu/packages/emacs.scm (emacspeak): New variable. > > [...] > >> + (add-after 'install-espeak-server 'wrap-program >> + (lambda* (#:key inputs outputs #:allow-other-keys) >> + (let* ((out (assoc-ref outputs "out")) >> + (emacspeak (string-append out "/bin/emacspeak")) >> + (espeak (string-append (assoc-ref inputs "espeak") >> + "/bin/espeak"))) >> + (wrap-program emacspeak >> + `("DTK_PROGRAM" ":" prefix (,espeak))))))) > > Please return #t here. Could you also add a note about what > =E2=80=98DTK_PROGRAM=E2=80=99 is and what component honors it? > >> + (home-page "http://emacspeak.sourceforge.net") >> + (synopsis "Audio desktop interface for Emacs") >> + (description >> + "Emacspeak is an Emacs subsystem that provides complete speech >> access.") > > Could you expound a bit, probably borrowing bits from their home page? > > Otherwise LGTM. OK with these changes! > > Thanks, > Ludo=E2=80=99. Pushed to master with the required changes. Thanks for the review. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEg7ZwOtzKO2lLzi2m5qXuPBlGeg0FAljs9K0ACgkQ5qXuPBlG eg0a8Q/8CUuA1g+eSPB+4Rj1cdhix5xWIv6vNWl2PI8+sQuND1NUOd81mHe+8pr3 qWZfMgVxipxHWIgvlwhw1r7VRoRH2DwT6KAYYsLOFD5K7QpTFKggRcvfONbx9fFg wfnQsMm1rMvZUvyjpzOVdBH1Y/rxQTT+4It6DMUP8iQiGZoMn/O8R8hYjnyQfh4P kHwdpuHJsyzpBLtOExqqiQuaAwOivQDj7HoKi3DoZgzHHZngausRpPb78WHvL2cJ RzTtIVuQ0TV8V+/sGtNBRUMV9pwTFPKoNRulxzHoumCnK+PQYcYHkQd48W3bOTo5 pgjUNbFeVefRfvchsvUd3G/Bw9gtYa1WQwFVDvgVEFg0zlMqYZYWE2LaIckDwpud Wt/1MyMFs9BACf/VGZ4VSQdrBmjrn9xjkz3IpVyJSCcsMGIW/4AtgAGM+0PeAmsj jbVtDSF8agjBEmBdZYpbwtkJ2Dfi5lItV6bKTpoRd6p7iT2ZPuM3sMaeZM4lqzcs qSY6ug1zTv6dRndc0WUzb17vBSm7Di9NTSB5QrdIqYMgj/6XwFrXslYX72TiuqIs RTlW9n2CtwNK4yDMLC3q0bkgzwICKgIbCzT0xOdbu1i1cSeZrdDhnRFiHifjiVIH z3/iDGR8Zp+Q93TtbhdFz6FgJPN5ThpFnkFus4D+cY0aBay7L6Q= =6lmv -----END PGP SIGNATURE----- --=-=-=--