From: "Ludovic Courtès" <ludo@gnu.org>
To: Diego Nicola Barbato <dnbarbato@posteo.de>
Cc: 35493@debbugs.gnu.org
Subject: [bug#35493] [PATCH 1/3] gnu: slim: Allow customisation of Xorg display.
Date: Wed, 08 May 2019 12:29:42 +0200 [thread overview]
Message-ID: <87v9ylz1bd.fsf@gnu.org> (raw)
In-Reply-To: <87tve6orqb.fsf@GlaDOS.home> (Diego Nicola Barbato's message of "Tue, 07 May 2019 23:54:36 +0200")
[-- Attachment #1: Type: text/plain, Size: 859 bytes --]
Hi,
Diego Nicola Barbato <dnbarbato@posteo.de> skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
[...]
>> Perhaps a simple fix is, when there’s only one server launched, to have
>> the Shepherd service provide both ‘xorg-server-vtN’ and ‘xorg-server’.
>> Or to special-case vt7 such that the service for vt7 provides both
>> ‘xorg-server’ and ‘xorg-server-vt7’.
>>
>> Thoughts?
>
> How about changing the default value of vt to #f and having the Shepherd
> service provide ‘xorg-server-vtN’ only if vt is set to "vtN" and
> ‘xorg-server’ otherwise. That way the name of the default Shepherd
> service would not change.
I think I would prefer special-casing vt7, as shown below. That way the
‘vt’ field would always be a string, which looks more consistent to me.
Thoughts?
Thanks,
Ludo’.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 785 bytes --]
diff --git a/gnu/services/xorg.scm b/gnu/services/xorg.scm
index 65e9d48915..f7c8684738 100644
--- a/gnu/services/xorg.scm
+++ b/gnu/services/xorg.scm
@@ -549,8 +549,11 @@ reboot_cmd " shepherd "/sbin/reboot\n"
(list (shepherd-service
(documentation "Xorg display server")
- (provision (list (symbol-append 'xorg-server-
- (string->symbol vt))))
+ (provision (cons (symbol-append 'xorg-server-
+ (string->symbol vt))
+ (if (string=? vt "vt7")
+ '(xorg-server)
+ '())))
(requirement '(user-processes host-name udev))
(start
#~(lambda ()
next prev parent reply other threads:[~2019-05-08 10:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 18:19 [bug#35493] [PATCH 0/3] Allow multiple SLiM services Diego Nicola Barbato
2019-04-29 18:20 ` [bug#35493] [PATCH 1/3] gnu: slim: Allow customisation of Xorg display Diego Nicola Barbato
2019-05-06 8:35 ` Ludovic Courtès
2019-05-06 11:31 ` Diego Nicola Barbato
2019-05-07 13:55 ` Ludovic Courtès
2019-05-07 21:54 ` Diego Nicola Barbato
2019-05-08 10:29 ` Ludovic Courtès [this message]
2019-05-08 20:12 ` Diego Nicola Barbato
2019-05-09 10:19 ` bug#35493: " Ludovic Courtès
2019-04-29 18:20 ` [bug#35493] [PATCH 2/3] services: slim: Allow SLiM to be started on multiple ttys Diego Nicola Barbato
2019-04-29 18:20 ` [bug#35493] [PATCH 3/3] doc: Document 'display' and 'vt' fields of 'slim-configuration' Diego Nicola Barbato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9ylz1bd.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=35493@debbugs.gnu.org \
--cc=dnbarbato@posteo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).