From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:58270) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hOJpv-0004jk-RP for guix-patches@gnu.org; Wed, 08 May 2019 06:30:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hOJpt-0004Hb-T3 for guix-patches@gnu.org; Wed, 08 May 2019 06:30:07 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46846) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hOJpq-0004Fi-AH for guix-patches@gnu.org; Wed, 08 May 2019 06:30:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hOJpp-0001p6-V5 for guix-patches@gnu.org; Wed, 08 May 2019 06:30:01 -0400 Subject: [bug#35493] [PATCH 1/3] gnu: slim: Allow customisation of Xorg display. Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <871s1kad42.fsf@GlaDOS.home> <87zho88yh4.fsf@GlaDOS.home> <87muk0m13s.fsf@gnu.org> <874l67rf8o.fsf@GlaDOS.home> <87woj25pxy.fsf@gnu.org> <87tve6orqb.fsf@GlaDOS.home> Date: Wed, 08 May 2019 12:29:42 +0200 In-Reply-To: <87tve6orqb.fsf@GlaDOS.home> (Diego Nicola Barbato's message of "Tue, 07 May 2019 23:54:36 +0200") Message-ID: <87v9ylz1bd.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Diego Nicola Barbato Cc: 35493@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Diego Nicola Barbato skribis: > Ludovic Court=C3=A8s writes: [...] >> Perhaps a simple fix is, when there=E2=80=99s only one server launched, = to have >> the Shepherd service provide both =E2=80=98xorg-server-vtN=E2=80=99 and = =E2=80=98xorg-server=E2=80=99. >> Or to special-case vt7 such that the service for vt7 provides both >> =E2=80=98xorg-server=E2=80=99 and =E2=80=98xorg-server-vt7=E2=80=99. >> >> Thoughts? > > How about changing the default value of vt to #f and having the Shepherd > service provide =E2=80=98xorg-server-vtN=E2=80=99 only if vt is set to "v= tN" and > =E2=80=98xorg-server=E2=80=99 otherwise. That way the name of the defaul= t Shepherd > service would not change. I think I would prefer special-casing vt7, as shown below. That way the =E2=80=98vt=E2=80=99 field would always be a string, which looks more consi= stent to me. Thoughts? Thanks, Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/gnu/services/xorg.scm b/gnu/services/xorg.scm index 65e9d48915..f7c8684738 100644 --- a/gnu/services/xorg.scm +++ b/gnu/services/xorg.scm @@ -549,8 +549,11 @@ reboot_cmd " shepherd "/sbin/reboot\n" (list (shepherd-service (documentation "Xorg display server") - (provision (list (symbol-append 'xorg-server- - (string->symbol vt)))) + (provision (cons (symbol-append 'xorg-server- + (string->symbol vt)) + (if (string=? vt "vt7") + '(xorg-server) + '()))) (requirement '(user-processes host-name udev)) (start #~(lambda () --=-=-=--