unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#37180] [PATCH] gnu: gcl: Enable tests.
@ 2019-08-25 15:42 Kei Kebreau
  2019-08-25 15:44 ` Kei Kebreau
  0 siblings, 1 reply; 3+ messages in thread
From: Kei Kebreau @ 2019-08-25 15:42 UTC (permalink / raw)
  To: 37180

This patch enables tests in GNU Common Lisp and also seems to repair Maxima's
build failure on master (at least on x86_64). Review and more testing would be
appreciated.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [bug#37180] [PATCH] gnu: gcl: Enable tests.
  2019-08-25 15:42 [bug#37180] [PATCH] gnu: gcl: Enable tests Kei Kebreau
@ 2019-08-25 15:44 ` Kei Kebreau
  2019-09-02 18:16   ` bug#37180: " Kei Kebreau
  0 siblings, 1 reply; 3+ messages in thread
From: Kei Kebreau @ 2019-08-25 15:44 UTC (permalink / raw)
  To: 37180; +Cc: Kei Kebreau

* gnu/packages/lisp.scm (gcl)[arguments]: Remove #:tests? flag and set the
  #:test-target to "ansi-tests/test_results".
---
 gnu/packages/lisp.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
index d32f4b19bd..2c08e06a55 100644
--- a/gnu/packages/lisp.scm
+++ b/gnu/packages/lisp.scm
@@ -113,7 +113,7 @@
       (build-system gnu-build-system)
       (arguments
        `(#:parallel-build? #f  ; The build system seems not to be thread safe.
-         #:tests? #f  ; There does not seem to be make check or anything similar.
+         #:test-target "ansi-tests/test_results"
          #:configure-flags '("--enable-ansi") ; required for use by the maxima package
          #:make-flags (list
                        (string-append "GCL_CC=" (assoc-ref %build-inputs "gcc")
-- 
2.23.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#37180: [PATCH] gnu: gcl: Enable tests.
  2019-08-25 15:44 ` Kei Kebreau
@ 2019-09-02 18:16   ` Kei Kebreau
  0 siblings, 0 replies; 3+ messages in thread
From: Kei Kebreau @ 2019-09-02 18:16 UTC (permalink / raw)
  To: 37180-done

Kei Kebreau <kkebreau@posteo.net> writes:

> * gnu/packages/lisp.scm (gcl)[arguments]: Remove #:tests? flag and set the
>   #:test-target to "ansi-tests/test_results".
> ---
>  gnu/packages/lisp.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
> index d32f4b19bd..2c08e06a55 100644
> --- a/gnu/packages/lisp.scm
> +++ b/gnu/packages/lisp.scm
> @@ -113,7 +113,7 @@
>        (build-system gnu-build-system)
>        (arguments
>         `(#:parallel-build? #f  ; The build system seems not to be thread safe.
> -         #:tests? #f  ; There does not seem to be make check or anything similar.
> +         #:test-target "ansi-tests/test_results"
>           #:configure-flags '("--enable-ansi") ; required for use by the maxima package
>           #:make-flags (list
>                         (string-append "GCL_CC=" (assoc-ref %build-inputs "gcc")

Pushed to master. The patch doesn't appear to negatively affect the
i686-linux, x86_64-linux and armhf-linux architectures.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-09-02 18:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-25 15:42 [bug#37180] [PATCH] gnu: gcl: Enable tests Kei Kebreau
2019-08-25 15:44 ` Kei Kebreau
2019-09-02 18:16   ` bug#37180: " Kei Kebreau

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).