unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#37979] [PATCH 1/1] * audio.scm (define public lilv): enable python bindings
@ 2019-10-29  9:45 Florian Paul Schmidt
  2019-10-30  9:48 ` Mathieu Othacehe
  0 siblings, 1 reply; 3+ messages in thread
From: Florian Paul Schmidt @ 2019-10-29  9:45 UTC (permalink / raw)
  To: 37979

[-- Attachment #1: Type: text/plain, Size: 0 bytes --]



[-- Attachment #2: 0001-audio.scm-define-public-lilv-enable-python-bindings-.patch --]
[-- Type: text/x-patch, Size: 2181 bytes --]

From 5afa9eac9c34c2e74114f96a6fe746a571b752ee Mon Sep 17 00:00:00 2001
From: Florian Paul Schmidt <florian_paul.schmidt@uni-bielefeld.de>
Date: Tue, 29 Oct 2019 10:34:45 +0100
Subject: [PATCH 1/1] * audio.scm (define public lilv): enable python bindings
 to be built

---
 gnu/packages/audio.scm | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 88f3b5eccd..6438e4e3c6 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -1828,6 +1828,7 @@ included are the command line utilities @code{send_osc} and @code{dump_osc}.")
     (build-system waf-build-system)
     (arguments
      `(#:tests? #f                      ; no check target
+       #:configure-flags (list "--bindings")
        #:phases
        (modify-phases %standard-phases
          (add-before
@@ -1836,6 +1837,16 @@ included are the command line utilities @code{send_osc} and @code{dump_osc}.")
             (setenv "LDFLAGS"
                     (string-append "-Wl,-rpath="
                                    (assoc-ref outputs "out") "/lib"))
+            #t))
+         (add-after
+           'unpack 'full-store-path-to-shared-library
+           (lambda* (#:key outputs #:allow-other-keys)
+             (chdir "bindings/python")
+             (substitute*
+                 "lilv.py"
+               (("liblilv-0.so") (string-append (assoc-ref outputs "out")
+                                                "/lib/liblilv-0.so")))
+             (chdir "../../")
             #t)))))
     ;; Required by lilv-0.pc.
     (propagated-inputs
@@ -1844,8 +1855,9 @@ included are the command line utilities @code{send_osc} and @code{dump_osc}.")
        ("sord" ,sord)
        ("sratom" ,sratom)))
     (native-inputs
-     `(("pkg-config" ,pkg-config)))
-    (home-page "https://drobilla.net/software/lilv/")
+     `(("python" ,python)
+       ("pkg-config" ,pkg-config)))
+    (home-page "https://drobilla.net/software/lilv")
     (synopsis "Library to simplify use of LV2 plugins in applications")
     (description
      "Lilv is a C library to make the use of LV2 plugins as simple as possible
-- 
2.23.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [bug#37979] [PATCH 1/1] * audio.scm (define public lilv): enable python bindings
  2019-10-29  9:45 [bug#37979] [PATCH 1/1] * audio.scm (define public lilv): enable python bindings Florian Paul Schmidt
@ 2019-10-30  9:48 ` Mathieu Othacehe
  2023-05-28 21:36   ` bug#37979: " Jelle Licht
  0 siblings, 1 reply; 3+ messages in thread
From: Mathieu Othacehe @ 2019-10-30  9:48 UTC (permalink / raw)
  To: 37979


Hello,

You can use with-directory-excursion instead of doing:

--8<---------------cut here---------------start------------->8---
(chdir "bindings/python")
...
(chdir "../..")
--8<---------------cut here---------------end--------------->8---

Also the commit title should be:

gnu: lilv: Enable python bindings.

Can you please send a v2 :) ?

Thanks,

Mathieu

^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#37979: [PATCH 1/1] * audio.scm (define public lilv): enable python bindings
  2019-10-30  9:48 ` Mathieu Othacehe
@ 2023-05-28 21:36   ` Jelle Licht
  0 siblings, 0 replies; 3+ messages in thread
From: Jelle Licht @ 2023-05-28 21:36 UTC (permalink / raw)
  To: 37979-done; +Cc: Mathieu Othacehe


The lilv on master seems to expose python bindings, closing.




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-05-28 21:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-29  9:45 [bug#37979] [PATCH 1/1] * audio.scm (define public lilv): enable python bindings Florian Paul Schmidt
2019-10-30  9:48 ` Mathieu Othacehe
2023-05-28 21:36   ` bug#37979: " Jelle Licht

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).