unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Brett Gilio <brettg@posteo.net>
Cc: 38325@debbugs.gnu.org
Subject: [bug#38325] [PATCH 1/2] gnu: Add tdlib.
Date: Tue, 26 Nov 2019 11:51:00 +0100	[thread overview]
Message-ID: <87v9r67vxn.fsf@gnu.org> (raw)
In-Reply-To: <87mucnviyy.fsf@posteo.net> (Brett Gilio's message of "Fri, 22 Nov 2019 12:55:49 -0600")

Hello!

Brett Gilio <brettg@posteo.net> skribis:

>>From c47ed88ed3945fd7dbdee2b7e507ec512dd799be Mon Sep 17 00:00:00 2001
> From: Brett Gilio <brettg@posteo.net>
> Date: Fri, 22 Nov 2019 12:53:32 -0600
> Subject: [PATCH 1/2] gnu: Add tdlib.
>
> * gnu/packages/messaging.scm (tdlib): New variable.

[...]

> +      (build-system cmake-build-system)
> +      (arguments
> +       `(#:tests? #f))

Apparently there are tests.  Could you look into enabling them?

If some of them fail, we should investigate.

Last thing: please address ‘guix lint’ warnings, I think there’s a
couple of them.  :-)

Thank you,
Ludo’.

  reply	other threads:[~2019-11-26 10:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-22 18:55 [bug#38325] [PATCH 1/2] gnu: Add tdlib Brett Gilio
2019-11-26 10:51 ` Ludovic Courtès [this message]
2019-11-26 19:33   ` Brett Gilio
2019-11-26 20:58     ` Ludovic Courtès
2019-11-27  8:09 ` [bug#38325] [PATCH] " Brett Gilio
2019-11-27  8:18   ` Brett Gilio
2019-11-28 19:08     ` Brett Gilio
2019-11-29 13:10   ` bug#38325: " Ludovic Courtès
2019-11-29 19:08     ` [bug#38325] " Brett Gilio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9r67vxn.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=38325@debbugs.gnu.org \
    --cc=brettg@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).