From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:34507)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iZYRu-0001Ol-Vr
 for guix-patches@gnu.org; Tue, 26 Nov 2019 05:52:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iZYRu-0000BX-3Q
 for guix-patches@gnu.org; Tue, 26 Nov 2019 05:52:02 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:44664)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iZYRu-0000BO-09
 for guix-patches@gnu.org; Tue, 26 Nov 2019 05:52:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iZYRt-00005P-VA
 for guix-patches@gnu.org; Tue, 26 Nov 2019 05:52:01 -0500
Subject: [bug#38325] [PATCH 1/2] gnu: Add tdlib.
Resent-Message-ID: <handler.38325.B38325.157476547032730@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <87mucnviyy.fsf@posteo.net>
Date: Tue, 26 Nov 2019 11:51:00 +0100
In-Reply-To: <87mucnviyy.fsf@posteo.net> (Brett Gilio's message of "Fri, 22
 Nov 2019 12:55:49 -0600")
Message-ID: <87v9r67vxn.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Brett Gilio <brettg@posteo.net>
Cc: 38325@debbugs.gnu.org

Hello!

Brett Gilio <brettg@posteo.net> skribis:

>>>From c47ed88ed3945fd7dbdee2b7e507ec512dd799be Mon Sep 17 00:00:00 2001
> From: Brett Gilio <brettg@posteo.net>
> Date: Fri, 22 Nov 2019 12:53:32 -0600
> Subject: [PATCH 1/2] gnu: Add tdlib.
>
> * gnu/packages/messaging.scm (tdlib): New variable.

[...]

> +      (build-system cmake-build-system)
> +      (arguments
> +       `(#:tests? #f))

Apparently there are tests.  Could you look into enabling them?

If some of them fail, we should investigate.

Last thing: please address =E2=80=98guix lint=E2=80=99 warnings, I think th=
ere=E2=80=99s a
couple of them.  :-)

Thank you,
Ludo=E2=80=99.