unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: "Jakub Kądziołka" <kuba@kadziolka.net>
Cc: 40643@debbugs.gnu.org
Subject: [bug#40643] [PATCH] git-version: Handle invalid arguments gracefully
Date: Fri, 17 Apr 2020 23:16:44 +0200	[thread overview]
Message-ID: <87v9lx95j7.fsf@gnu.org> (raw)
In-Reply-To: <20200415151824.22988-1-kuba@kadziolka.net> ("Jakub \=\?utf-8\?B\?S8SFZHppb8WCa2EiJ3M\=\?\= message of "Wed, 15 Apr 2020 17:18:23 +0200")

Hi Jakub,

Jakub Kądziołka <kuba@kadziolka.net> skribis:

> * guix/git-download.scm (git-version): Add a check for commit ID length.
> ---
> If you're curious for the motivation, see [1]. This took a while to
> debug, so I'm hoping to ease this for the next person who inevitably
> stumbles upon this. Is a change like this okay?

Yes, I think so.  The ‘error’ procedure is not great, we would rather
use ‘raise’ with a ‘&message’ condition (which additionally allows for
i18n) but it’s no big deal here.

Thanks,
Ludo’.

  reply	other threads:[~2020-04-17 21:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-15 15:18 [bug#40643] [PATCH] git-version: Handle invalid arguments gracefully Jakub Kądziołka
2020-04-17 21:16 ` Ludovic Courtès [this message]
2020-04-21 22:45   ` Jakub Kądziołka
2020-04-22 15:10     ` Ludovic Courtès
2020-04-23 13:32       ` bug#40643: " Jakub Kądziołka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9lx95j7.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=40643@debbugs.gnu.org \
    --cc=kuba@kadziolka.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).