From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:44674)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jPYMC-0000LG-Dy
 for guix-patches@gnu.org; Fri, 17 Apr 2020 17:17:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jPYMB-0007tC-GI
 for guix-patches@gnu.org; Fri, 17 Apr 2020 17:17:04 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:58503)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jPYM9-0007qs-PB
 for guix-patches@gnu.org; Fri, 17 Apr 2020 17:17:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jPYM9-0000eU-Kl
 for guix-patches@gnu.org; Fri, 17 Apr 2020 17:17:01 -0400
Subject: [bug#40643] [PATCH] git-version: Handle invalid arguments gracefully
Resent-Message-ID: <handler.40643.B40643.15871582172491@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20200415151824.22988-1-kuba@kadziolka.net>
Date: Fri, 17 Apr 2020 23:16:44 +0200
In-Reply-To: <20200415151824.22988-1-kuba@kadziolka.net> ("Jakub
 \=\?utf-8\?B\?S8SFZHppb8WCa2EiJ3M\=\?\=
 message of "Wed, 15 Apr 2020 17:18:23 +0200")
Message-ID: <87v9lx95j7.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Jakub =?UTF-8?Q?K=C4=85dzio=C5=82ka?= <kuba@kadziolka.net>
Cc: 40643@debbugs.gnu.org

Hi Jakub,

Jakub K=C4=85dzio=C5=82ka <kuba@kadziolka.net> skribis:

> * guix/git-download.scm (git-version): Add a check for commit ID length.
> ---
> If you're curious for the motivation, see [1]. This took a while to
> debug, so I'm hoping to ease this for the next person who inevitably
> stumbles upon this. Is a change like this okay?

Yes, I think so.  The =E2=80=98error=E2=80=99 procedure is not great, we wo=
uld rather
use =E2=80=98raise=E2=80=99 with a =E2=80=98&message=E2=80=99 condition (wh=
ich additionally allows for
i18n) but it=E2=80=99s no big deal here.

Thanks,
Ludo=E2=80=99.