[bug#38953] gnu: Add gnome-photos.

[bug#38953] gnu: Add gnome-photos.

[Raghav Gururajan]

[-- Attachment #1: Type: text/plain, Size: 99 bytes --]

Hello Guix!

Please find the attached patch to add gnome-photos.

Thank you!

Regards,
RG.

[-- Attachment #2: gnome-photos.patch --]
[-- Type: application/octet-stream, Size: 3973 bytes --]

From 5a89896856e83f99305b792a133298bc7f413f3d Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sat, 4 Jan 2020 23:27:24 -0500
Subject: [PATCH] gnu: Add gnome-photos.

* gnu/packages/gnome-xyz (gnome-photos): New variable.
---
 gnu/packages/gnome-xyz.scm | 67 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 67 insertions(+)

diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
index 0fc721b7d3..91fe9086da 100644
--- a/gnu/packages/gnome-xyz.scm
+++ b/gnu/packages/gnome-xyz.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2019 Leo Prikler <leo.prikler@student.tugraz.at>
 ;;; Copyright © 2019 Alexandros Theodotou <alex@zrythm.org>
 ;;; Copyright © 2019 Giacomo Leidi <goodoldpaul@autistici.org>
+;;; Copyright        2019 Raghav Gururajan <raghavgururajan@disroot.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -21,18 +22,84 @@
 (define-module (gnu packages gnome-xyz)
   #:use-module (guix build-system trivial)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system meson)
+  #:use-module (guix download)
   #:use-module (guix git-download)
   #:use-module (guix packages)
+  #:use-module (guix utils)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (gnu packages base)
   #:use-module (gnu packages bash)
+  #:use-module (gnu packages freedesktop)
+  #:use-module (gnu packages gettext)
+  #:use-module (gnu packages gimp)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gnome)
   #:use-module (gnu packages gtk)
+  #:use-module (gnu packages image)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages ruby)
+  #:use-module (gnu packages version-control)
   #:use-module (gnu packages xml))
 
+(define-public gnome-photos
+  (package
+   (name "gnome-photos")
+   (version "3.34.0")
+   (source (origin
+            (method url-fetch)
+            (uri (string-append "mirror://gnome/sources/" name "/"
+                                (version-major+minor version) "/"
+                                name "-" version ".tar.xz"))
+            (sha256
+             (base32
+              "12j455id5g616cn0nnj73v83aqgpavrsqszw1r5yhbpyc76lg03m"))))
+   (build-system meson-build-system)
+   (arguments
+    `(
+      ;; dogtail test-suite not available.
+      #:configure-flags `("-Ddogtail=false")
+      ;; FIX-ME: runpath vaildation always fail.
+      #:validate-runpath? #f))
+   (native-inputs
+    `(("glib:bin" ,glib "bin")
+      ("itstool" ,itstool)
+      ("pkg-config" ,pkg-config)))
+   (inputs
+    `(("adwaita-icon-theme" ,adwaita-icon-theme)
+      ("babl" ,babl)
+      ("cairo" ,cairo)
+      ("dbus" ,dbus)
+      ("desktop-file-utils" ,desktop-file-utils)
+      ("gdk-pixbuf" ,gdk-pixbuf+svg)
+      ("gegl" ,gegl)
+      ("gettext" ,gettext-minimal)
+      ("geocode-glib" ,geocode-glib)
+      ("gexiv2" ,gexiv2)
+      ("git" ,git-minimal)
+      ("gnome-online-accounts" ,gnome-online-accounts)
+      ("gnome-online-miners" ,gnome-online-miners)
+      ("gobject-introspection" ,gobject-introspection)
+      ("grilo" ,grilo)
+      ("grilo-plugins" ,grilo-plugins)
+      ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
+      ("gtk+:bin" ,gtk+ "bin")
+      ("libdazzle" ,libdazzle)
+      ("libgdata" ,libgdata)
+      ("libgfbgraph" ,gfbgraph)
+      ("libjpeg" ,libjpeg)
+      ("libpng" ,libpng)
+      ("librest" ,rest)
+      ("pygobject" ,python-pygobject)
+      ("tracker" ,tracker)
+      ("tracker-miners" ,tracker-miners)))
+   (synopsis "Access, organize and share your photos on GNOME desktop")
+   (description "GNOME Photos is a simple and elegant replacement for
+using a file manager to deal with photos. Enhance, crop and edit in a snap.
+Seamless cloud integration is offered through GNOME Online Accounts.")
+   (home-page "https://wiki.gnome.org/Apps/Photos")
+   (license license:gpl2)))
+
 (define-public matcha-theme
   (package
     (name "matcha-theme")
-- 
2.24.1

[bug#38953] v2

[Raghav Gururajan]

[-- Attachment #1.1: Type: text/plain, Size: 4 bytes --]

v2

[-- Attachment #1.2: gnome-photos.patch --]
[-- Type: text/x-patch, Size: 4197 bytes --]

From 4187d1411efd96de2791643d667b1158c2caeba9 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Tue, 7 Jan 2020 00:54:29 -0500
Subject: [PATCH] gnu: Add gnome-photos.

* gnu/packages/gnome-xyz.scm (gnome-photos): New variable.
---
 gnu/packages/gnome-xyz.scm | 71 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 71 insertions(+)

diff --git a/gnu/packages/gnome-xyz.scm b/gnu/packages/gnome-xyz.scm
index 0fc721b7d3..e3f67a38d8 100644
--- a/gnu/packages/gnome-xyz.scm
+++ b/gnu/packages/gnome-xyz.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2019 Leo Prikler <leo.prikler@student.tugraz.at>
 ;;; Copyright © 2019 Alexandros Theodotou <alex@zrythm.org>
 ;;; Copyright © 2019 Giacomo Leidi <goodoldpaul@autistici.org>
+;;; Copyright        2019 Raghav Gururajan <raghavgururajan@disroot.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -21,18 +22,88 @@
 (define-module (gnu packages gnome-xyz)
   #:use-module (guix build-system trivial)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system meson)
+  #:use-module (guix download)
   #:use-module (guix git-download)
   #:use-module (guix packages)
+  #:use-module (guix utils)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (gnu packages base)
   #:use-module (gnu packages bash)
+  #:use-module (gnu packages freedesktop)
+  #:use-module (gnu packages gettext)
+  #:use-module (gnu packages gimp)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gnome)
   #:use-module (gnu packages gtk)
+  #:use-module (gnu packages image)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages ruby)
+  #:use-module (gnu packages version-control)
   #:use-module (gnu packages xml))
 
+(define-public gnome-photos
+  (package
+   (name "gnome-photos")
+   (version "3.34.0")
+   (source (origin
+            (method url-fetch)
+            (uri (string-append "mirror://gnome/sources/" name "/"
+                                (version-major+minor version) "/"
+                                name "-" version ".tar.xz"))
+            (sha256
+             (base32
+              "12j455id5g616cn0nnj73v83aqgpavrsqszw1r5yhbpyc76lg03m"))))
+   (build-system meson-build-system)
+   (arguments
+    `(#:glib-or-gtk? #t
+      ;; dogtail test-suite not available.
+      #:configure-flags `("-Ddogtail=false")
+      #:configure-flags
+       (list "-Dsystemduserunitdir=no"
+             "-Dtmpfilesdir=no"
+             ;; Required for RUNPATH validation.
+             (string-append "-Dc_link_args=-Wl,-rpath="
+                            (assoc-ref %outputs "out") "/lib/gnome-photos"))))
+   (native-inputs
+    `(("glib:bin" ,glib "bin")
+      ("itstool" ,itstool)
+      ("pkg-config" ,pkg-config)))
+   (inputs
+    `(("adwaita-icon-theme" ,adwaita-icon-theme)
+      ("babl" ,babl)
+      ("cairo" ,cairo)
+      ("dbus" ,dbus)
+      ("desktop-file-utils" ,desktop-file-utils)
+      ("gdk-pixbuf" ,gdk-pixbuf+svg)
+      ("gegl" ,gegl)
+      ("gettext" ,gettext-minimal)
+      ("geocode-glib" ,geocode-glib)
+      ("gexiv2" ,gexiv2)
+      ("git" ,git-minimal)
+      ("gnome-online-accounts" ,gnome-online-accounts)
+      ("gnome-online-miners" ,gnome-online-miners)
+      ("gobject-introspection" ,gobject-introspection)
+      ("grilo" ,grilo)
+      ("grilo-plugins" ,grilo-plugins)
+      ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
+      ("gtk+:bin" ,gtk+ "bin")
+      ("libdazzle" ,libdazzle)
+      ("libgdata" ,libgdata)
+      ("libgfbgraph" ,gfbgraph)
+      ("libjpeg" ,libjpeg)
+      ("libpng" ,libpng)
+      ("librest" ,rest)
+      ("pygobject" ,python-pygobject)
+      ("tracker" ,tracker)
+      ("tracker-miners" ,tracker-miners)))
+   (synopsis "Access, organize and share your photos on GNOME desktop")
+   (description "GNOME Photos is a simple and elegant replacement for
+using a file manager to deal with photos. Enhance, crop and edit in a snap.
+Seamless cloud integration is offered through GNOME Online Accounts.")
+   (home-page "https://wiki.gnome.org/Apps/Photos")
+   (license license:gpl2)))
+
 (define-public matcha-theme
   (package
     (name "matcha-theme")
-- 
2.24.1


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#38953] v3

[Raghav Gururajan]

[-- Attachment #1.1: Type: text/plain, Size: 4 bytes --]

v3

[-- Attachment #1.2: gnome-photos.patch --]
[-- Type: text/x-patch, Size: 3505 bytes --]

From 84354284df02d7bb254f4dfe453b11ba19d43ebd Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Wed, 8 Jan 2020 08:26:55 -0500
Subject: [PATCH] gnu: Add gnome-photos.

* gnu/packages/gnome.scm (gnome-photos): New variable.
---
 gnu/packages/gnome.scm | 65 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 65 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index e71cc2fee2..3d333ef505 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -97,6 +97,7 @@
   #:use-module (gnu packages game-development)
   #:use-module (gnu packages gettext)
   #:use-module (gnu packages ghostscript)
+  #:use-module (gnu packages gimp)
   #:use-module (gnu packages gl)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gnupg)
@@ -246,6 +247,70 @@ Desktop.  It is designed to be as simple as possible and has some unique
 features to enable users to create their discs easily and quickly.")
     (license license:gpl2+)))
 
+(define-public gnome-photos
+  (package
+   (name "gnome-photos")
+   (version "3.34.0")
+   (source (origin
+            (method url-fetch)
+            (uri (string-append "mirror://gnome/sources/" name "/"
+                                (version-major+minor version) "/"
+                                name "-" version ".tar.xz"))
+            (sha256
+             (base32
+              "12j455id5g616cn0nnj73v83aqgpavrsqszw1r5yhbpyc76lg03m"))))
+   (build-system meson-build-system)
+   (arguments
+    `(#:glib-or-gtk? #t
+      #:configure-flags
+       (list "-Dsystemduserunitdir=no"
+             "-Dtmpfilesdir=no"
+             ;; Dogtail test-suite not available.
+             "-Ddogtail=false"
+             ;; Required for RUNPATH validation.
+             (string-append "-Dc_link_args=-Wl,-rpath="
+                            (assoc-ref %outputs "out") "/lib/gnome-photos"))))
+   (native-inputs
+    `(("glib:bin" ,glib "bin")
+      ("gtk+:bin" ,gtk+ "bin")
+      ("itstool" ,itstool)
+      ("pkg-config" ,pkg-config)))
+   (inputs
+    `(("adwaita-icon-theme" ,adwaita-icon-theme)
+      ("babl" ,babl)
+      ("cairo" ,cairo)
+      ("dbus" ,dbus)
+      ("desktop-file-utils" ,desktop-file-utils)
+      ("gdk-pixbuf" ,gdk-pixbuf+svg)
+      ("gegl" ,gegl)
+      ("gettext" ,gettext-minimal)
+      ("geocode-glib" ,geocode-glib)
+      ("gexiv2" ,gexiv2)
+      ("git" ,git-minimal)
+      ("glib" ,glib)
+      ("gnome-online-accounts" ,gnome-online-accounts)
+      ("gnome-online-miners" ,gnome-online-miners)
+      ("gobject-introspection" ,gobject-introspection)
+      ("grilo" ,grilo)
+      ("grilo-plugins" ,grilo-plugins)
+      ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
+      ("gtk+" ,gtk+)
+      ("libdazzle" ,libdazzle)
+      ("libgdata" ,libgdata)
+      ("libgfbgraph" ,gfbgraph)
+      ("libjpeg" ,libjpeg)
+      ("libpng" ,libpng)
+      ("librest" ,rest)
+      ("pygobject" ,python-pygobject)
+      ("tracker" ,tracker)
+      ("tracker-miners" ,tracker-miners)))
+   (synopsis "Access, organize and share your photos on GNOME desktop")
+   (description "GNOME Photos is a simple and elegant replacement for
+using a file manager to deal with photos.  Enhance, crop and edit in a snap.
+Seamless cloud integration is offered through GNOME Online Accounts.")
+   (home-page "https://wiki.gnome.org/Apps/Photos")
+   (license license:gpl2)))
+
 (define-public gnome-menus
   (package
     (name "gnome-menus")
-- 
2.24.1


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#38953] v3

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 300 bytes --]

Hi Raghav,

please make the things which are only required for the build and not required
runtime native-inputs.

Most likely those are at least dbus, desktop-file-utils, gettext, git,
gobject-introspection, gsettings-desktop-schemas.

Does the feature that uses python-pygobject work fine?

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[bug#38953] gnome-photos v4

[Raghav Gururajan]

[-- Attachment #1: Type: text/plain, Size: 17 bytes --]

gnome-photos v4

[-- Attachment #2: gnome-photos.patch --]
[-- Type: application/octet-stream, Size: 3161 bytes --]

From 0a7284cfb3f3cdffd6a76202133240cfc4b06526 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Tue, 14 Jan 2020 18:27:39 -0500
Subject: [PATCH] gnu: Add gnome-photos.

* gnu/packages/gnome.scm (gnome-photos): New variable.
---
 gnu/packages/gnome.scm | 62 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 62 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 0e41faa458..e808d2aca5 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -246,6 +246,68 @@ Desktop.  It is designed to be as simple as possible and has some unique
 features to enable users to create their discs easily and quickly.")
     (license license:gpl2+)))
 
+(define-public gnome-photos
+  (package
+   (name "gnome-photos")
+   (version "3.34.0")
+   (source (origin
+            (method url-fetch)
+            (uri (string-append "mirror://gnome/sources/" name "/"
+                                (version-major+minor version) "/"
+                                name "-" version ".tar.xz"))
+            (sha256
+             (base32
+              "12j455id5g616cn0nnj73v83aqgpavrsqszw1r5yhbpyc76lg03m"))))
+   (build-system meson-build-system)
+   (arguments
+    `(#:glib-or-gtk? #t
+      #:configure-flags
+       (list "-Dsystemduserunitdir=no"
+             "-Dtmpfilesdir=no"
+             ;; Dogtail test-suite not available.
+             "-Ddogtail=false"
+             ;; Required for RUNPATH validation.
+             (string-append "-Dc_link_args=-Wl,-rpath="
+                            (assoc-ref %outputs "out") "/lib/gnome-photos"))))
+   (native-inputs
+    `(("dbus" ,dbus)
+      ("desktop-file-utils" ,desktop-file-utils)
+      ("gettext" ,gettext-minimal)
+      ("git" ,git-minimal)
+      ("glib:bin" ,glib "bin")
+      ("gobject-introspection" ,gobject-introspection)
+      ("gsettings-desktop-schemas" ,gsettings-desktop-schemas)
+      ("itstool" ,itstool)
+      ("pkg-config" ,pkg-config)))
+   (inputs
+    `(("adwaita-icon-theme" ,adwaita-icon-theme)
+      ("babl" ,babl)
+      ("cairo" ,cairo)
+      ("gdk-pixbuf" ,gdk-pixbuf+svg)
+      ("gegl" ,gegl)
+      ("geocode-glib" ,geocode-glib)
+      ("gexiv2" ,gexiv2)
+      ("gnome-online-accounts" ,gnome-online-accounts)
+      ("gnome-online-miners" ,gnome-online-miners)
+      ("grilo" ,grilo)
+      ("grilo-plugins" ,grilo-plugins)
+      ("gtk+" ,gtk+)
+      ("libdazzle" ,libdazzle)
+      ("libgdata" ,libgdata)
+      ("libgfbgraph" ,gfbgraph)
+      ("libjpeg" ,libjpeg)
+      ("libpng" ,libpng)
+      ("librest" ,rest)
+      ("pygobject" ,python-pygobject)
+      ("tracker" ,tracker)
+      ("tracker-miners" ,tracker-miners)))
+   (synopsis "Access, organize and share your photos on GNOME desktop")
+   (description "GNOME Photos is a simple and elegant replacement for
+using a file manager to deal with photos.  Enhance, crop and edit in a snap.
+Seamless cloud integration is offered through GNOME Online Accounts.")
+   (home-page "https://wiki.gnome.org/Apps/Photos")
+   (license license:gpl3+)))
+
 (define-public gnome-music
   (package
    (name "gnome-music")
-- 
2.24.1

[bug#38953] gnu: Add gnome-photos.

[Pierre Neidhardt]

[-- Attachment #1: Type: text/plain, Size: 103 bytes --]

Can this be closed now that this is merged on master?

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#38953: gnu: Add gnome-photos.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 167 bytes --]

On Sat, Aug 22, 2020 at 12:34:07PM +0200, Pierre Neidhardt wrote:
> Can this be closed now that this is merged on master?

Sure, we can always reopen bugs if we want.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]