From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Leo Prikler <leo.prikler@student.tugraz.at>
Cc: 45132@debbugs.gnu.org
Subject: [bug#45132] [PATCH 0/2] QC Ren'py package
Date: Thu, 10 Dec 2020 12:09:36 +0100 [thread overview]
Message-ID: <87v9d9hq8f.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <02e03c983db083b554991ee295b366adedd95bc5.camel@student.tugraz.at> (Leo Prikler's message of "Wed, 09 Dec 2020 15:55:02 +0100")
Hello,
Leo Prikler <leo.prikler@student.tugraz.at> writes:
> perhaps a bit overdue, the 10th of October marks the anniversary of my
> first contribution to Guix. A bit later and with a broken git setup,
> I've added a package for Ren'py, which was finally upstreamed towards
> the end of October.
Time flies!
> Today, I am again revisiting that package, as back then there were
> several steps skipped in packaging, that should not have been skipped.
> The following patch set drops generated sources from both Ren'py and
> its fork of pygame, and also has Ren'py use the already existing
> fribidi package.
It looks good. I suggest adding #t at the end of the snippet as long as
next core-updates merge has not happened.
Could you also mention the origin of the patch (unless it is yours, of
course, in which case you can mention your name)?
Otherwise, LGTM.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-12-10 11:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 14:55 [bug#45132] [PATCH 0/2] QC Ren'py package Leo Prikler
2020-12-09 14:56 ` [bug#45132] [PATCH 1/2] gnu: pygame-sdl2-for-renpy: Drop generated sources in snippet Leo Prikler
2020-12-09 14:56 ` [bug#45132] [PATCH 2/2] gnu: renpy: Use system fribidi and drop generated sources Leo Prikler
2020-12-10 11:09 ` Nicolas Goaziou [this message]
2020-12-10 12:28 ` [bug#45132] [PATCH 0/2] QC Ren'py package Leo Prikler
2020-12-10 19:03 ` [bug#45132] [PATCH v2 1/2] gnu: pygame-sdl2-for-renpy: Drop generated sources in snippet Leo Prikler
2020-12-10 19:03 ` [bug#45132] [PATCH v2 2/2] gnu: renpy: Use system fribidi and drop generated sources Leo Prikler
2020-12-12 20:16 ` bug#45132: [PATCH v2 1/2] gnu: pygame-sdl2-for-renpy: Drop generated sources in snippet Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9d9hq8f.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=45132@debbugs.gnu.org \
--cc=leo.prikler@student.tugraz.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).