From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id GNI/NTMC0l9HTgAA0tVLHw (envelope-from ) for ; Thu, 10 Dec 2020 11:10:43 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id uOQYMTMC0l8hQgAA1q6Kng (envelope-from ) for ; Thu, 10 Dec 2020 11:10:43 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 616F694042E for ; Thu, 10 Dec 2020 11:10:43 +0000 (UTC) Received: from localhost ([::1]:35572 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1knJqL-00057N-6z for larch@yhetil.org; Thu, 10 Dec 2020 06:10:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41416) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knJpi-0004tw-SZ for guix-patches@gnu.org; Thu, 10 Dec 2020 06:10:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:53809) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1knJpi-00028J-KP for guix-patches@gnu.org; Thu, 10 Dec 2020 06:10:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1knJpi-0006hn-Aj for guix-patches@gnu.org; Thu, 10 Dec 2020 06:10:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45132] [PATCH 0/2] QC Ren'py package Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 10 Dec 2020 11:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45132 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Prikler Received: via spool by 45132-submit@debbugs.gnu.org id=B45132.160759858625737 (code B ref 45132); Thu, 10 Dec 2020 11:10:02 +0000 Received: (at 45132) by debbugs.gnu.org; 10 Dec 2020 11:09:46 +0000 Received: from localhost ([127.0.0.1]:37121 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knJpS-0006h2-9o for submit@debbugs.gnu.org; Thu, 10 Dec 2020 06:09:46 -0500 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:49251) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1knJpQ-0006go-HT for 45132@debbugs.gnu.org; Thu, 10 Dec 2020 06:09:45 -0500 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 9564A1BF20C; Thu, 10 Dec 2020 11:09:37 +0000 (UTC) From: Nicolas Goaziou References: <02e03c983db083b554991ee295b366adedd95bc5.camel@student.tugraz.at> Date: Thu, 10 Dec 2020 12:09:36 +0100 In-Reply-To: <02e03c983db083b554991ee295b366adedd95bc5.camel@student.tugraz.at> (Leo Prikler's message of "Wed, 09 Dec 2020 15:55:02 +0100") Message-ID: <87v9d9hq8f.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 45132@debbugs.gnu.org Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.30 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 616F694042E X-Spam-Score: -2.30 X-Migadu-Scanner: scn1.migadu.com X-TUID: otaKqTFymHLv Hello, Leo Prikler writes: > perhaps a bit overdue, the 10th of October marks the anniversary of my > first contribution to Guix. A bit later and with a broken git setup, > I've added a package for Ren'py, which was finally upstreamed towards > the end of October. Time flies! > Today, I am again revisiting that package, as back then there were > several steps skipped in packaging, that should not have been skipped. > The following patch set drops generated sources from both Ren'py and > its fork of pygame, and also has Ren'py use the already existing > fribidi package. It looks good. I suggest adding #t at the end of the snippet as long as next core-updates merge has not happened. Could you also mention the origin of the patch (unless it is yours, of course, in which case you can mention your name)? Otherwise, LGTM. Regards, -- Nicolas Goaziou