unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Xinglu Chen <public@yoctocell.xyz>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 50874@debbugs.gnu.org
Subject: [bug#50874] [PATCH] lint: Check if HTTPS version of HTTP URL exists.
Date: Sat, 09 Oct 2021 11:57:08 +0200	[thread overview]
Message-ID: <87v926ldvv.fsf@yoctocell.xyz> (raw)
In-Reply-To: <877devwj95.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 747 bytes --]

On Sat, Oct 02 2021, Ludovic Courtès wrote:

> Hi,
>
> Xinglu Chen <public@yoctocell.xyz> skribis:
>
>> * guix/lint.scm (check-if-https-uri-exists?): New procedure.
>> (check-home-page, check-source): Use it.
>
> Applied, thanks!

Was it?  I don’t see it in the log.

>> I don’t really know how to test this while making it future-proof, any
>> suggestions?
>
> I don’t know either, since we don’t have an easy way to spin up an HTTPS
> server.  I think it’s okay to leave it as is, for lack of a better idea.
>
> However, this version of the patch leads to test failures in
> tests/lint.scm (“Connection refused”).

Thanks for catching this; I will look into it.  Good that you didn’t
apply it then.  :-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

  reply	other threads:[~2021-10-09  9:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-28 19:09 [bug#50874] [PATCH] lint: Check if HTTPS version of HTTP URL exists Xinglu Chen
2021-10-02 15:15 ` Ludovic Courtès
2021-10-09  9:57   ` Xinglu Chen [this message]
2021-10-09 10:11     ` Xinglu Chen
2021-10-10 13:12     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v926ldvv.fsf@yoctocell.xyz \
    --to=public@yoctocell.xyz \
    --cc=50874@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).