[bug#58055] [PATCH 0/1] Add emacs-orgmd

[bug#58055] [PATCH 0/1] Add emacs-orgmd

[Fredrik Salomonsson]

An Emacs' Org mode watchlist manager and OMDb API client.

Fredrik Salomonsson (1):
  gnu: Add emacs-orgmdb.

 gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)


base-commit: fc07082fe3d750c85282c4aa57d01a36ebe9296b
-- 
2.37.3

[bug#58055] [PATCH 1/1] gnu: Add emacs-orgmdb.

[Fredrik Salomonsson]

* gnu/packages/emacs-xyz.scm (emacs-orgmdb): New variable.
---
 gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 0e3e0be3b8..5572564b6d 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -6010,6 +6010,32 @@ (define-public emacs-org-now
 their original location with another.")
       (license license:gpl3+))))
 
+(define-public emacs-orgmdb
+  (package
+   (name "emacs-orgmdb")
+   (version "0.5")
+   (source
+    (origin
+     (method git-fetch)
+     (uri (git-reference
+           (url "https://github.com/isamert/orgmdb.el")
+           (commit "66c13abdb84e0f0a31bae6cfda27478771d58d8e")))
+     (sha256
+      (base32
+       "1hvxha0ih9jhvwj07l6jnpf2vzhgvb6ii73g49c8saxld61l0frf"))
+     (file-name (git-file-name name version))))
+   (build-system emacs-build-system)
+   (propagated-inputs
+    (list
+     emacs-s
+     emacs-dash
+     emacs-org))
+   (home-page "https://github.com/isamert/orgmdb.el")
+   (synopsis "An Emacs' Org mode watchlist manager and OMDb API client")
+   (description "This package adds tools for managing your watchlist in Emacs' Org
+mode and some functions for interacting with the OMDb API.")
+   (license license:gpl3+)))
+
 (define-public emacs-rich-minority
   (package
     (name "emacs-rich-minority")
-- 
2.37.3

bug#58055: [PATCH 1/1] gnu: Add emacs-orgmdb.

[Nicolas Goaziou]

Hello,

Fredrik Salomonsson <plattfot@posteo.net> writes:

> * gnu/packages/emacs-xyz.scm (emacs-orgmdb): New variable.

Thank you. I applied the patch with the following changes:

> +   (propagated-inputs
> +    (list
> +     emacs-s
> +     emacs-dash
> +     emacs-org))

I reordered inputs alphabetically.

> +   (home-page "https://github.com/isamert/orgmdb.el")
> +   (synopsis "An Emacs' Org mode watchlist manager and OMDb API client")

I removed the article "An".

Regards,
-- 
Nicolas Goaziou

[bug#58055] [PATCH 0/1] Add emacs-orgmd

[Maxime Devos]

[-- Attachment #1.1.1: Type: text/plain, Size: 842 bytes --]



On 25-09-2022 02:37, Fredrik Salomonsson wrote:
> An Emacs' Org mode watchlist manager and OMDb API client.
> 
> Fredrik Salomonsson (1):
>    gnu: Add emacs-orgmdb.
> 
>   gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
>   1 file changed, 26 insertions(+)
> 
> 
> base-commit: fc07082fe3d750c85282c4aa57d01a36ebe9296b

Have you tested this in a pure environment?  Going by 
<https://github.com/isamert/orgmdb.el/blob/66c13abdb84e0f0a31bae6cfda27478771d58d8e/orgmdb.el#L663>, 
it requires 'fd' to work, but 'fd is not mentioned in the propagated 
inputs and neither is it mentioned in the 'inputs' + appropriate 
substitute*.

I recommend the latter, and in the future having a quick look at the 
source code to see if it invokes some software (Emacs additions are 
usually short).

Greetings,
Maxime.

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

[bug#58055] [PATCH 0/1] Add emacs-orgmd

[Nicolas Goaziou]

Hello,

Maxime Devos <maximedevos@telenet.be> writes:

> On 25-09-2022 02:37, Fredrik Salomonsson wrote:
>> An Emacs' Org mode watchlist manager and OMDb API client.
>> Fredrik Salomonsson (1):
>>    gnu: Add emacs-orgmdb.
>>   gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
>>   1 file changed, 26 insertions(+)
>> base-commit: fc07082fe3d750c85282c4aa57d01a36ebe9296b
>
> Have you tested this in a pure environment?  Going by
> <https://github.com/isamert/orgmdb.el/blob/66c13abdb84e0f0a31bae6cfda27478771d58d8e/orgmdb.el#L663>,
> it requires 'fd' to work, but 'fd is not mentioned in the propagated
> inputs and neither is it mentioned in the 'inputs' + appropriate
> substitute*.
>
> I recommend the latter, and in the future having a quick look at the
> source code to see if it invokes some software (Emacs additions are
> usually short).

Fixed in 31593237f6aa82ce29e0ecf1911e64713e21ddcb. Thanks for the heads up.

Regards,
-- 
Nicolas Goaziou