* [bug#64930] [PATCH] guix: Also print the user when SSH auth fails.
@ 2023-07-29 12:02 Attila Lendvai
2023-08-16 16:43 ` Simon Tournier
0 siblings, 1 reply; 3+ messages in thread
From: Attila Lendvai @ 2023-07-29 12:02 UTC (permalink / raw)
To: 64930
Cc: Attila Lendvai, Christopher Baines, Josselin Poiret,
Ludovic Courtès, Mathieu Othacehe, Ricardo Wurmus,
Simon Tournier, Tobias Geerinckx-Rice
---
i have added this when i was debugging a guix deploy issue,
and i thought it should be useful for others, too.
guix/ssh.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/guix/ssh.scm b/guix/ssh.scm
index b7b9807ebf..91d61fc3c0 100644
--- a/guix/ssh.scm
+++ b/guix/ssh.scm
@@ -175,8 +175,8 @@ (define* (open-ssh-session host #:key user port identity
(disconnect! session)
(raise (condition
(&message
- (message (format #f (G_ "SSH authentication failed for '~a': ~a~%")
- host (get-error session)))))))))))
+ (message (format #f (G_ "SSH authentication failed for '~a@~a': ~a~%")
+ user host (get-error session)))))))))))
(x
;; Connection failed or timeout expired.
(raise (formatted-message (G_ "SSH connection to '~a' failed: ~a~%")
base-commit: e43cbeafd1b632f39b08b3644af5230d5350a656
prerequisite-patch-id: 6793c8ad24215c5f14ce71a4741fff5f6ccd7eeb
prerequisite-patch-id: 3a8dd737d11f37987641af9bc7f512a0bb1a1591
prerequisite-patch-id: f6456f2bf0b7b078318d16b958c14816eb45ace5
prerequisite-patch-id: 52e0d371350dbeb839990acd0bbe70bc5b5b995b
--
2.40.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [bug#64930] [PATCH] guix: Also print the user when SSH auth fails.
2023-07-29 12:02 [bug#64930] [PATCH] guix: Also print the user when SSH auth fails Attila Lendvai
@ 2023-08-16 16:43 ` Simon Tournier
2023-08-22 9:07 ` bug#64930: " Ludovic Courtès
0 siblings, 1 reply; 3+ messages in thread
From: Simon Tournier @ 2023-08-16 16:43 UTC (permalink / raw)
To: Attila Lendvai, 64930
Cc: Josselin Poiret, Tobias Geerinckx-Rice, Mathieu Othacehe,
Ludovic Courtès, Christopher Baines, Ricardo Wurmus,
Attila Lendvai
Hi,
On Sat, 29 Jul 2023 at 14:02, Attila Lendvai <attila.lendvai@gmail.com> wrote:
> - (message (format #f (G_ "SSH authentication failed for '~a': ~a~%")
> - host (get-error session)))))))))))
> + (message (format #f (G_ "SSH authentication failed for '~a@~a': ~a~%")
> + user host (get-error session)))))))))))
This LGTM. Is it possible that ’user’ is not set?
Cheers,
simon
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#64930: [PATCH] guix: Also print the user when SSH auth fails.
2023-08-16 16:43 ` Simon Tournier
@ 2023-08-22 9:07 ` Ludovic Courtès
0 siblings, 0 replies; 3+ messages in thread
From: Ludovic Courtès @ 2023-08-22 9:07 UTC (permalink / raw)
To: Simon Tournier
Cc: Josselin Poiret, Attila Lendvai, Mathieu Othacehe,
Tobias Geerinckx-Rice, 64930-done, Christopher Baines,
Ricardo Wurmus, Attila Lendvai
Hi,
Simon Tournier <zimon.toutoune@gmail.com> skribis:
> On Sat, 29 Jul 2023 at 14:02, Attila Lendvai <attila.lendvai@gmail.com> wrote:
>
>> - (message (format #f (G_ "SSH authentication failed for '~a': ~a~%")
>> - host (get-error session)))))))))))
>> + (message (format #f (G_ "SSH authentication failed for '~a@~a': ~a~%")
>> + user host (get-error session)))))))))))
>
> This LGTM. Is it possible that ’user’ is not set?
Right, USER can be #f. I fixed this and applied it.
Thanks Attila & Simon!
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-22 9:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-29 12:02 [bug#64930] [PATCH] guix: Also print the user when SSH auth fails Attila Lendvai
2023-08-16 16:43 ` Simon Tournier
2023-08-22 9:07 ` bug#64930: " Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).