unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 26264@debbugs.gnu.org
Subject: bug#26264: [PATCH 0/1] Use '@' to separate name, version in package-full-name
Date: Mon, 08 May 2017 14:39:03 +0200	[thread overview]
Message-ID: <87tw4vo74o.fsf@gnu.org> (raw)
In-Reply-To: <6a792b17-4e9f-c7ec-6934-8a04a9236bd1@tobias.gr> (Tobias Geerinckx-Rice's message of "Sun, 7 May 2017 23:13:29 +0200")

Heya!

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> On 07/05/17 17:37, Ludovic Courtès wrote:
>> WDYT of making it:
>>   (define* (package-full-name package #:optional (separator "@"))
>>     …)
>> ?
>> (I think I suggested it somewhere, but maybe not.  :-))
>
> You did! I simply forgot to address it explicitly (‘I'm sticking...’).
>
>> That would make the adjustments to places that need a hyphen slightly
>> shorter.
>
> I considered it back when, but decided not to because it just felt...
> wrong. That's it. My intuitive, rambling reasoning:
>
> - All of the patched ex-callers are manually constructing some raw
>   file or directory name. It includes the package's name and version
>   in some way, but not really Guix's abstract concept of a
>   ‘package-full-name’ atom. It just happened to be the same string.
>
> - Making ‘separator’ configurable turns ‘package-full-name’ into
>   ‘package-name-version-join’. If one cares about the separator,
>   one also cares about the components, at which point one should just
>   call string-join explicitly. Doing so isn't ugly, and is more clear.
>
> Does that make any sense?

I does, I wondered about that too.

So yeah, please push the patches, thanks!

>> Thanks, and good luck with your new $DAYJOB!
>
> Thanks! It doesn't involve computers, so it won't last.

Heheh.  :-)

Ludo’.

  reply	other threads:[~2017-05-08 12:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170326122555.22366-1-alex@pompo.co>
     [not found] ` <6da6e290-feed-e500-e53a-d308e5dc9dde@tobias.gr>
     [not found]   ` <877f3bx4m3.fsf@gmail.com>
2017-03-28 15:03     ` bug#26264: [PATCH 0/1] Use '@' to separate name, version in package-full-name Ludovic Courtès
2017-03-28 15:19       ` Tobias Geerinckx-Rice
     [not found]         ` <fe8b8924-3c64-e478-4745-24a692db3a91@tobias.gr>
     [not found]           ` <87o9wl1j3k.fsf@gnu.org>
2017-03-28 19:49             ` Tobias Geerinckx-Rice
2017-05-06 18:32         ` Tobias Geerinckx-Rice
2017-05-07 15:37           ` Ludovic Courtès
2017-05-07 21:13             ` Tobias Geerinckx-Rice
2017-05-08 12:39               ` Ludovic Courtès [this message]
2017-05-20  9:28           ` Alex Sassmannshausen
2017-05-31 12:11             ` Ludovic Courtès
     [not found] ` <20170326122555.22366-2-alex@pompo.co>
2017-03-28 15:06   ` bug#26265: [PATCH 1/1] packages: Add optional `for-ui` param to `package-full-name` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tw4vo74o.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=26264@debbugs.gnu.org \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).