From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33656) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d7hxO-0006Cc-8q for guix-patches@gnu.org; Mon, 08 May 2017 08:40:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d7hxK-00051Q-AQ for guix-patches@gnu.org; Mon, 08 May 2017 08:40:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:34840) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d7hxK-00051D-6O for guix-patches@gnu.org; Mon, 08 May 2017 08:40:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d7hxJ-0003J7-Tc for guix-patches@gnu.org; Mon, 08 May 2017 08:40:01 -0400 Subject: bug#26264: [PATCH 0/1] Use '@' to separate name, version in package-full-name Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20170326122555.22366-1-alex@pompo.co> <6da6e290-feed-e500-e53a-d308e5dc9dde@tobias.gr> <877f3bx4m3.fsf@gmail.com> <87h92d30lw.fsf@gnu.org> <22f867cf-18f8-c08c-259e-afe86bff5ac6@tobias.gr> <45019b9a-565a-82a9-a0de-249cfe211cfa@tobias.gr> <87bmr4ptj6.fsf@gnu.org> <6a792b17-4e9f-c7ec-6934-8a04a9236bd1@tobias.gr> Date: Mon, 08 May 2017 14:39:03 +0200 In-Reply-To: <6a792b17-4e9f-c7ec-6934-8a04a9236bd1@tobias.gr> (Tobias Geerinckx-Rice's message of "Sun, 7 May 2017 23:13:29 +0200") Message-ID: <87tw4vo74o.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Tobias Geerinckx-Rice Cc: 26264@debbugs.gnu.org Heya! Tobias Geerinckx-Rice skribis: > On 07/05/17 17:37, Ludovic Court=C3=A8s wrote: >> WDYT of making it: >> (define* (package-full-name package #:optional (separator "@")) >> =E2=80=A6) >> ? >> (I think I suggested it somewhere, but maybe not. :-)) > > You did! I simply forgot to address it explicitly (=E2=80=98I'm sticking.= ..=E2=80=99). > >> That would make the adjustments to places that need a hyphen slightly >> shorter. > > I considered it back when, but decided not to because it just felt... > wrong. That's it. My intuitive, rambling reasoning: > > - All of the patched ex-callers are manually constructing some raw > file or directory name. It includes the package's name and version > in some way, but not really Guix's abstract concept of a > =E2=80=98package-full-name=E2=80=99 atom. It just happened to be the sa= me string. > > - Making =E2=80=98separator=E2=80=99 configurable turns =E2=80=98package-= full-name=E2=80=99 into > =E2=80=98package-name-version-join=E2=80=99. If one cares about the sep= arator, > one also cares about the components, at which point one should just > call string-join explicitly. Doing so isn't ugly, and is more clear. > > Does that make any sense? I does, I wondered about that too. So yeah, please push the patches, thanks! >> Thanks, and good luck with your new $DAYJOB! > > Thanks! It doesn't involve computers, so it won't last. Heheh. :-) Ludo=E2=80=99.