* [bug#29404] [PATCH] bootloader: extlinux: Fix device tree path.
@ 2017-11-22 19:17 Mathieu Othacehe
2017-11-23 15:38 ` Ludovic Courtès
2017-11-25 8:44 ` Danny Milosavljevic
0 siblings, 2 replies; 5+ messages in thread
From: Mathieu Othacehe @ 2017-11-22 19:17 UTC (permalink / raw)
To: 29404
* gnu/bootloader/extlinux.scm (extlinux-configuration-file): Use kernel
directory to format device tree file path.
---
gnu/bootloader/extlinux.scm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gnu/bootloader/extlinux.scm b/gnu/bootloader/extlinux.scm
index e5fdeb580..0db5598fc 100644
--- a/gnu/bootloader/extlinux.scm
+++ b/gnu/bootloader/extlinux.scm
@@ -53,7 +53,7 @@ corresponding to old generations of the system."
APPEND ~a
~%"
#$label #$label
- #$kernel #$kernel #$initrd
+ #$kernel (dirname #$kernel) #$initrd
(string-join (list #$@kernel-arguments)))))
(define builder
--
2.15.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [bug#29404] [PATCH] bootloader: extlinux: Fix device tree path.
2017-11-22 19:17 [bug#29404] [PATCH] bootloader: extlinux: Fix device tree path Mathieu Othacehe
@ 2017-11-23 15:38 ` Ludovic Courtès
2017-11-23 18:31 ` Mathieu Othacehe
2017-11-25 8:44 ` Danny Milosavljevic
1 sibling, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2017-11-23 15:38 UTC (permalink / raw)
To: Mathieu Othacehe; +Cc: 29404
Hello!
Mathieu Othacehe <m.othacehe@gmail.com> skribis:
> * gnu/bootloader/extlinux.scm (extlinux-configuration-file): Use kernel
> directory to format device tree file path.
> ---
> gnu/bootloader/extlinux.scm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/bootloader/extlinux.scm b/gnu/bootloader/extlinux.scm
> index e5fdeb580..0db5598fc 100644
> --- a/gnu/bootloader/extlinux.scm
> +++ b/gnu/bootloader/extlinux.scm
> @@ -53,7 +53,7 @@ corresponding to old generations of the system."
> APPEND ~a
> ~%"
> #$label #$label
> - #$kernel #$kernel #$initrd
> + #$kernel (dirname #$kernel) #$initrd
What was wrong previously? How does this affect the
“installed-extlinux-os” test?
If you’re confident that’s fine with me, but I’m just curious. :-)
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#29404] [PATCH] bootloader: extlinux: Fix device tree path.
2017-11-23 15:38 ` Ludovic Courtès
@ 2017-11-23 18:31 ` Mathieu Othacehe
2017-11-23 21:41 ` Ludovic Courtès
0 siblings, 1 reply; 5+ messages in thread
From: Mathieu Othacehe @ 2017-11-23 18:31 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 29404
Hi Ludo !
> What was wrong previously? How does this affect the
> “installed-extlinux-os” test?
The issue was FDTDIR was set to /gnu/store/...-linux/bzImage/lib/dtbs
instead of /gnu/store/...-linux/lib/dtbs. This has gone unnoticed
because device tree are not used on intel architecture.
So installed-extlinux-os must behave exactly the same because FDTDIR is
ignored.
Thanks for reviewing :)
Mathieu
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#29404] [PATCH] bootloader: extlinux: Fix device tree path.
2017-11-23 18:31 ` Mathieu Othacehe
@ 2017-11-23 21:41 ` Ludovic Courtès
0 siblings, 0 replies; 5+ messages in thread
From: Ludovic Courtès @ 2017-11-23 21:41 UTC (permalink / raw)
To: Mathieu Othacehe; +Cc: 29404
Mathieu Othacehe <m.othacehe@gmail.com> skribis:
>> What was wrong previously? How does this affect the
>> “installed-extlinux-os” test?
>
> The issue was FDTDIR was set to /gnu/store/...-linux/bzImage/lib/dtbs
> instead of /gnu/store/...-linux/lib/dtbs. This has gone unnoticed
> because device tree are not used on intel architecture.
>
> So installed-extlinux-os must behave exactly the same because FDTDIR is
> ignored.
Got it, makes perfect sense.
Thank you!
Ludo’.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#29404] [PATCH] bootloader: extlinux: Fix device tree path.
2017-11-22 19:17 [bug#29404] [PATCH] bootloader: extlinux: Fix device tree path Mathieu Othacehe
2017-11-23 15:38 ` Ludovic Courtès
@ 2017-11-25 8:44 ` Danny Milosavljevic
1 sibling, 0 replies; 5+ messages in thread
From: Danny Milosavljevic @ 2017-11-25 8:44 UTC (permalink / raw)
To: Mathieu Othacehe; +Cc: 29404
LGTM!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-11-25 8:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-22 19:17 [bug#29404] [PATCH] bootloader: extlinux: Fix device tree path Mathieu Othacehe
2017-11-23 15:38 ` Ludovic Courtès
2017-11-23 18:31 ` Mathieu Othacehe
2017-11-23 21:41 ` Ludovic Courtès
2017-11-25 8:44 ` Danny Milosavljevic
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).