[bug#29434] [PATCH 0/2] gnu: python-internetarchive: Update to 1.7.4 and enable tests.

[bug#29434] [PATCH 0/2] gnu: python-internetarchive: Update to 1.7.4 and enable tests.

[Oleg Pykhalov]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: [PATCH 0/2] gnu: python-internetarchive: Update to 1.7.4 and enable tests. --]
[-- Type: text/x-patch, Size: 619 bytes --]

From d807d092719f22addc909cb5f6a5371cef1d2d6c Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust@gmail.com>
Date: Sat, 25 Nov 2017 11:13:55 +0300
Subject: [PATCH 0/2] gnu: python-internetarchive: Update to 1.7.4 and enable tests.

Hello Guix,

These patches update python-internetarchive to 1.7.4 and enable tests as
discussed in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28129

Oleg Pykhalov (2):
  gnu: python-internetarchive: Update to 1.7.4.
  gnu: python-internetarchive: Enable tests.

 gnu/packages/web.scm | 27 +++++++++++++--------------
 1 file changed, 13 insertions(+), 14 deletions(-)

-- 
2.15.0

[bug#29434] [PATCH 1/2] gnu: python-internetarchive: Update to 1.7.4.

[Oleg Pykhalov]

* gnu/packages/web.scm (python-internetarchive): Update to 1.7.4.
---
 gnu/packages/web.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index a4a8778ef..9e6ad5b69 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -5160,7 +5160,7 @@ command-line arguments or read from stdin.")
 (define-public python-internetarchive
   (package
     (name "python-internetarchive")
-    (version "1.7.1")
+    (version "1.7.4")
     (source
      (origin
        (method url-fetch)
@@ -5169,7 +5169,7 @@ command-line arguments or read from stdin.")
        (file-name (string-append name "-" version ".tar.gz"))
        (sha256
         (base32
-         "1lj4r0y67mwjns2gcjvw0y7m5x0vqir2iv7s4q2y93492azli1qh"))))
+         "0sdbb2ag6vmybi8zmbjszi492a587giaaqxyy1p6gy03cb8mc512"))))
     (build-system python-build-system)
     (arguments
      `(#:tests? #f ; 11 tests of 105 fail to mock "requests".
-- 
2.15.0

[bug#29434] [PATCH 2/2] gnu: python-internetarchive: Enable tests.

[Oleg Pykhalov]

* gnu/packages/web.scm (python-internetarchive): Enable tests.
---
 gnu/packages/web.scm | 23 +++++++++++------------
 1 file changed, 11 insertions(+), 12 deletions(-)

diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index 9e6ad5b69..988a73170 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -5172,21 +5172,20 @@ command-line arguments or read from stdin.")
          "0sdbb2ag6vmybi8zmbjszi492a587giaaqxyy1p6gy03cb8mc512"))))
     (build-system python-build-system)
     (arguments
-     `(#:tests? #f ; 11 tests of 105 fail to mock "requests".
-       #:phases
+     `(#:phases
        (modify-phases %standard-phases
          (delete 'check)
          (add-after 'install 'check
-           (lambda* (#:key inputs outputs target (tests? (not target)) #:allow-other-keys)
-             (if tests?
-               (begin
-                 (add-installed-pythonpath inputs outputs)
-                 (setenv "PATH" (string-append (assoc-ref outputs "out") "/bin"
-                                               ":" (getenv "PATH")))
-                 (zero? (system* "py.test")))
-               (begin
-                 (format #t "test suite not run~%")
-                 #t)))))))
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (add-installed-pythonpath inputs outputs)
+             (setenv "PATH" (string-append (assoc-ref outputs "out") "/bin"
+                                           ":" (getenv "PATH")))
+             (zero? (system* "py.test" "-v" "-k"
+                             (string-append
+                              ;; This tests attempts to make a connection to
+                              ;; an external web service.
+                              "not test_get_item_with_kwargs"
+                              " and not test_ia"))))))))
     (propagated-inputs
      `(("python-requests" ,python-requests)
        ("python-jsonpatch" ,python-jsonpatch-0.4)
-- 
2.15.0

[bug#29434] [PATCH 2/2] gnu: python-internetarchive: Enable tests.

[Oleg Pykhalov]

Oleg Pykhalov <go.wigust@gmail.com> writes:

[...]

> +             (zero? (system* "py.test" "-v" "-k"
> +                             (string-append
> +                              ;; This tests attempts to make a connection to
> +                              ;; an external web service.
> +                              "not test_get_item_with_kwargs"
> +                              " and not test_ia"))))))))

Oh, probably better: These tests attempt to make a connection to an
external web service.  :-)

>      (propagated-inputs
>       `(("python-requests" ,python-requests)
>         ("python-jsonpatch" ,python-jsonpatch-0.4)

[bug#29434] [PATCH 2/2] gnu: python-internetarchive: Enable tests.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 653 bytes --]

On Sat, Nov 25, 2017 at 11:30:45AM +0300, Oleg Pykhalov wrote:
> Oleg Pykhalov <go.wigust@gmail.com> writes:
> 
> [...]
> 
> > +             (zero? (system* "py.test" "-v" "-k"
> > +                             (string-append
> > +                              ;; This tests attempts to make a connection to
> > +                              ;; an external web service.
> > +                              "not test_get_item_with_kwargs"
> > +                              " and not test_ia"))))))))
> 
> Oh, probably better: These tests attempt to make a connection to an
> external web service.  :-)

Yes, that's more clear :) Thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[bug#29434] [PATCH 1/2] gnu: python-internetarchive: Update to 1.7.4.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 146 bytes --]

On Sat, Nov 25, 2017 at 11:21:57AM +0300, Oleg Pykhalov wrote:
> * gnu/packages/web.scm (python-internetarchive): Update to 1.7.4.

LGTM, thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[bug#29434] [PATCH 1/2] gnu: python-internetarchive: Update to 1.7.4.

[Oleg Pykhalov]

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

Hello Leo,

Leo Famulari <leo@famulari.name> writes:

> On Sat, Nov 25, 2017 at 11:21:57AM +0300, Oleg Pykhalov wrote:
>> * gnu/packages/web.scm (python-internetarchive): Update to 1.7.4.
>
> LGTM, thanks!

OK, pushed as:

- 25fa22a99b31c91dba398935ef9457a7664d8156
- 2cdf78df2d3d5d88c7e6908754233cf37cce1e61

Thanks,
Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

bug#29434: [PATCH 1/2] gnu: python-internetarchive: Update to 1.7.4.

[Oleg Pykhalov]