[bug#31173] [PATCH] gnu: Add python-onetimepass.

[Marius Bakke <mbakke@fastmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1280 bytes --]

Tomáš Čech <sleep_walker@gnu.org> writes:

> * gnu/packages/python.scm (python-onetimepass): New variable.

[...]

> +(define-public python-onetimepass
> +  (package
> +    (name "python-onetimepass")

Please check the indentation of this package.  Use
'./etc/indent-code.el' if you're not an emacs user.

> +    (version "1.0.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "onetimepass" version))
> +       (sha256
> +        (base32
> +         "09vagxgbq78wvq4xbikmn2hpqqsa2i96kqsmphf7dqynfv0dlsd5"))))
> +    (build-system python-build-system)
> +    (inputs
> +       `(("python-six" ,python-six)))

Should this not be a propagated input?

> +    (home-page "https://github.com/tadeck/onetimepass/")
> +    (synopsis "Python one-time password library")

Maybe s/Python// even.

> +    (description "Pyhton one-time password library for HMAC-based (HOTP) and
                      ^^^ typo (importo?)
> +time-based (TOTP) passwords.")

Please also turn this into a complete sentence.  "@code{onetimepass} is
a Python library for...".  Bonus points if you can mention use-cases and
in general expand on it :-)

> +    (license license:x11)))

I believe this is "expat".

Otherwise LGTM.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]