From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8Cvp-00014o-O9 for guix-patches@gnu.org; Mon, 16 Apr 2018 18:49:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8Cvm-0003y7-KP for guix-patches@gnu.org; Mon, 16 Apr 2018 18:49:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:48546) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f8Cvm-0003xT-GZ for guix-patches@gnu.org; Mon, 16 Apr 2018 18:49:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f8Cvm-00012g-7N for guix-patches@gnu.org; Mon, 16 Apr 2018 18:49:02 -0400 Subject: [bug#31173] [PATCH] gnu: Add python-onetimepass. Resent-Message-ID: From: Marius Bakke In-Reply-To: <20180416090552.14421-1-sleep_walker@gnu.org> References: <20180416090552.14421-1-sleep_walker@gnu.org> Date: Tue, 17 Apr 2018 00:47:59 +0200 Message-ID: <87tvsabwf4.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: =?UTF-8?Q?Tom=C3=A1=C5=A1_?= =?UTF-8?Q?=C4=8Cech?= , 31173@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Tom=C3=A1=C5=A1 =C4=8Cech writes: > * gnu/packages/python.scm (python-onetimepass): New variable. [...] > +(define-public python-onetimepass > + (package > + (name "python-onetimepass") Please check the indentation of this package. Use './etc/indent-code.el' if you're not an emacs user. > + (version "1.0.1") > + (source > + (origin > + (method url-fetch) > + (uri (pypi-uri "onetimepass" version)) > + (sha256 > + (base32 > + "09vagxgbq78wvq4xbikmn2hpqqsa2i96kqsmphf7dqynfv0dlsd5")))) > + (build-system python-build-system) > + (inputs > + `(("python-six" ,python-six))) Should this not be a propagated input? > + (home-page "https://github.com/tadeck/onetimepass/") > + (synopsis "Python one-time password library") Maybe s/Python// even. > + (description "Pyhton one-time password library for HMAC-based (HOTP)= and ^^^ typo (importo?) > +time-based (TOTP) passwords.") Please also turn this into a complete sentence. "@code{onetimepass} is a Python library for...". Bonus points if you can mention use-cases and in general expand on it :-) > + (license license:x11))) I believe this is "expat". Otherwise LGTM. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlrVKB8ACgkQoqBt8qM6 VPpfEgf+No5HJ2vBZo2H0C43dT5g0VSoiCQ75QnJwFGryd9IJ+Vign5ujGSoSNHQ 40twghkqJwVGT0Q52A9FqkMj7WW7xuxcocrE7LQ435lv1ouyaFG7JiTbMmCgzL82 aJ4Nc6pAcGPA/3Dc+/IUJrMhL098XHn/pij0JE7xByX6pIRthuzTy03oSRtnQCAC 73Hxou7o+WfnmiGPp7kbdK08+8tWpR0NFdS53lJLzc13bG6tjMShzUk6B5dsF+H0 ijwKVbNrQI3rRE4jOUAHfEkcvBA7aXYtmrOWgKZ1E6NVSKcefyOc0qQMfPYCbNaB DMhlDK30QTM3Sl9dnmUOHGo+xP8DcA== =C0nr -----END PGP SIGNATURE----- --=-=-=--