From: ludo@gnu.org (Ludovic Courtès)
To: Pierre Neidhardt <ambrevar@gmail.com>
Cc: 31114-done@debbugs.gnu.org
Subject: [bug#31114] [PATCH] gnu: Add fortune-mod.
Date: Mon, 23 Apr 2018 17:12:36 +0200 [thread overview]
Message-ID: <87tvs2yn17.fsf@gnu.org> (raw)
In-Reply-To: <87h8o7iddr.fsf@gmail.com> (Pierre Neidhardt's message of "Thu, 19 Apr 2018 18:04:08 +0530")
Hello,
Pierre Neidhardt <ambrevar@gmail.com> skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Hi Pierre,
>>
>> I’ve applied it all after fixing trivial issues reported by ‘guix lint’.
>> I was able to get a few fortune cookies already, so thank you. :-)
>
> I did run `guix lint` if I'm not mistaken, I don't remember any issue.
> What were those?
I think these were two-spaces-after-end-of-sentence-period in the
synopses/descriptions of the Perl packages, things like that.
>> Pierre Neidhardt <ambrevar@gmail.com> skribis:
>>
>>> + (native-inputs
>>> + `(("perl" ,perl)
>>> + ;; The following is only needed for tests.
>>> + ("perl-file-find-object" ,perl-file-find-object)
>>> + ("perl-test-differences" ,perl-test-differences)
>>> + ("perl-class-xsaccessor" ,perl-class-xsaccessor)
>>> + ("perl-io-all" ,perl-io-all)
>>> + ("perl-test-runvalgrind" ,perl-test-runvalgrind)
>>> + ("cmake-rules"
>>> + ,(origin
>>> + (method url-fetch)
>>> + (uri (string-append "https://bitbucket.org/shlomif/shlomif-cmake-modules/"
>>> + "raw/default/shlomif-cmake-modules/Shlomif_Common.cmake"))
>>> + (sha256
>>> + (base32 "0kx9s1qqhhzprp1w3b67xmsns0n0v506bg5hgrshxaxpy6lqiwb2"))))))
>>
>> I’m afraid the above URL is referring to the tip of that repository, and
>> thus that contents may change over time. Could you come up with a
>> stable URL, i.e., one that includes a commit ID?
>
> Sure, I think
>
> https://bitbucket.org/shlomif/shlomif-cmake-modules/raw/c505713d7a7cda608f97f01577e5868a711b883e/shlomif-cmake-modules/Shlomif_Common.cmake
>
> should do.
OK, I made the change.
> Out of curiosity, why did you close the bug / merge the patch with the
> URL issue mentioned above?
I didn’t consider it a showstopper, but I can understand arguments both
ways.
Thank you,
Ludo’.
next prev parent reply other threads:[~2018-04-23 15:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 17:32 [bug#31114] [PATCH] gnu: Add fortune-mod Pierre Neidhardt
2018-04-09 17:39 ` Pierre Neidhardt
2018-04-09 20:51 ` Ludovic Courtès
2018-04-10 7:05 ` Pierre Neidhardt
2018-04-10 7:24 ` Pierre Neidhardt
2018-04-10 10:14 ` Ludovic Courtès
2018-04-10 16:22 ` Pierre Neidhardt
2018-04-19 9:56 ` bug#31114: " Ludovic Courtès
2018-04-19 12:34 ` [bug#31114] " Pierre Neidhardt
2018-04-23 15:12 ` Ludovic Courtès [this message]
2018-04-09 20:55 ` Leo Famulari
2018-04-10 7:00 ` Pierre Neidhardt
2018-04-18 20:42 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvs2yn17.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=31114-done@debbugs.gnu.org \
--cc=ambrevar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).