From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48224) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fAd9P-0006GU-W6 for guix-patches@gnu.org; Mon, 23 Apr 2018 11:13:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fAd9K-0004BG-4t for guix-patches@gnu.org; Mon, 23 Apr 2018 11:13:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:57549) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fAd9K-0004BC-09 for guix-patches@gnu.org; Mon, 23 Apr 2018 11:13:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fAd9J-0007ms-P2 for guix-patches@gnu.org; Mon, 23 Apr 2018 11:13:01 -0400 Subject: [bug#31114] [PATCH] gnu: Add fortune-mod. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20180409173217.7629-1-ambrevar@gmail.com> <878t9w9t57.fsf@gmail.com> <877epggl1x.fsf@gnu.org> <87efjnfsmq.fsf@gmail.com> <87d0z7frr7.fsf@gmail.com> <87a7ub8j1b.fsf@gnu.org> <87efjnowut.fsf@gmail.com> <87a7tzmse1.fsf@gnu.org> <87h8o7iddr.fsf@gmail.com> Date: Mon, 23 Apr 2018 17:12:36 +0200 In-Reply-To: <87h8o7iddr.fsf@gmail.com> (Pierre Neidhardt's message of "Thu, 19 Apr 2018 18:04:08 +0530") Message-ID: <87tvs2yn17.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Pierre Neidhardt Cc: 31114-done@debbugs.gnu.org Hello, Pierre Neidhardt skribis: > Ludovic Court=C3=A8s writes: > >> Hi Pierre, >> >> I=E2=80=99ve applied it all after fixing trivial issues reported by =E2= =80=98guix lint=E2=80=99. >> I was able to get a few fortune cookies already, so thank you. :-) > > I did run `guix lint` if I'm not mistaken, I don't remember any issue. > What were those? I think these were two-spaces-after-end-of-sentence-period in the synopses/descriptions of the Perl packages, things like that. >> Pierre Neidhardt skribis: >> >>> + (native-inputs >>> + `(("perl" ,perl) >>> + ;; The following is only needed for tests. >>> + ("perl-file-find-object" ,perl-file-find-object) >>> + ("perl-test-differences" ,perl-test-differences) >>> + ("perl-class-xsaccessor" ,perl-class-xsaccessor) >>> + ("perl-io-all" ,perl-io-all) >>> + ("perl-test-runvalgrind" ,perl-test-runvalgrind) >>> + ("cmake-rules" >>> + ,(origin >>> + (method url-fetch) >>> + (uri (string-append "https://bitbucket.org/shlomif/shlomif-= cmake-modules/" >>> + "raw/default/shlomif-cmake-modules/Shlo= mif_Common.cmake")) >>> + (sha256 >>> + (base32 "0kx9s1qqhhzprp1w3b67xmsns0n0v506bg5hgrshxaxpy6lqi= wb2")))))) >> >> I=E2=80=99m afraid the above URL is referring to the tip of that reposit= ory, and >> thus that contents may change over time. Could you come up with a >> stable URL, i.e., one that includes a commit ID? > > Sure, I think > > https://bitbucket.org/shlomif/shlomif-cmake-modules/raw/c505713d7a7cda60= 8f97f01577e5868a711b883e/shlomif-cmake-modules/Shlomif_Common.cmake > > should do. OK, I made the change. > Out of curiosity, why did you close the bug / merge the patch with the > URL issue mentioned above? I didn=E2=80=99t consider it a showstopper, but I can understand arguments = both ways. Thank you, Ludo=E2=80=99.