From: ludo@gnu.org (Ludovic Courtès)
To: Alex Vong <alexvong1995@gmail.com>
Cc: 33215@debbugs.gnu.org
Subject: [bug#33215] [PATCH 05/11] guix: Add clojure-utils.
Date: Tue, 20 Nov 2018 22:55:27 +0100 [thread overview]
Message-ID: <87tvkbv2gg.fsf@gnu.org> (raw)
In-Reply-To: <871s86hck1.fsf@gmail.com> (Alex Vong's message of "Wed, 31 Oct 2018 14:09:50 +0800")
Hello!
I’m late to the party but I think there are things worth discussing
here. Danny, for non-trivial bits, in particular in the (guix …) name
space, I think we should ping people to get more detailed review before
merging.
Alex Vong <alexvong1995@gmail.com> skribis:
> From 857cce37325f01c26f79a6e15e33d7988ea4a0a2 Mon Sep 17 00:00:00 2001
> From: Alex Vong <alexvong1995@gmail.com>
> Date: Sun, 14 Oct 2018 03:09:48 +0800
> Subject: [PATCH 05/11] guix: Add clojure-utils.
>
> * guix/build/clojure-utils.scm: New file.
> * gnu/packages/lisp.scm (clojure)[arguments]: Use it.
> * Makefile.am (MODULES): Add it.
[...]
> +(define-module (guix build clojure-utils)
> + #:use-module (guix build utils)
> + #:use-module (ice-9 ftw)
> + #:use-module (ice-9 regex)
> + #:use-module (srfi srfi-1)
> + #:use-module (srfi srfi-26)
> + #:export (%clojure-regex
> + define-with-docs
> + install-doc))
> +
> +(define-syntax-rule (define-with-docs name docs val)
> + "Create top-level variable named NAME with doc string DOCS and value VAL."
> + (begin (define name val)
> + (set-object-property! name 'documentation docs)))
This is not necessarily a bad idea, but in general I’m very much in
favor of consistency: since we don’t use this anywhere else, I’d rather
not have it here either. We could discuss it separately, but IMO it
shouldn’t be buried in a Clojure patch.
Thus I’d be in favor of using the same style in this file as in the rest
of Guix.
WDYT?
Thanks,
Ludo’.
next prev parent reply other threads:[~2018-11-20 21:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 6:02 [bug#33215] [PATCH 00/11] build-system: Add 'clojure-build-system' Alex Vong
2018-10-31 6:05 ` [bug#33215] [PATCH 01/11] gnu: clojure: Move from java to lisp Alex Vong
2018-10-31 6:06 ` [bug#33215] [PATCH 02/11] gnu: clojure: Remove 'remove-archives' snippet Alex Vong
2018-10-31 6:07 ` [bug#33215] [PATCH 03/11] gnu: clojure: Refactor to ensure there's a single list of libraries Alex Vong
2018-10-31 6:08 ` [bug#33215] [PATCH 04/11] gnu: clojure: Use (guix build java-utils) to simplify build phases Alex Vong
2018-10-31 6:09 ` [bug#33215] [PATCH 05/11] guix: Add clojure-utils Alex Vong
2018-11-20 21:55 ` Ludovic Courtès [this message]
2018-11-21 14:35 ` Alex Vong
2018-11-21 22:12 ` Ludovic Courtès
2018-10-31 6:10 ` [bug#33215] [PATCH 06/11] build-system: Add 'clojure-build-system' Alex Vong
2018-11-20 22:03 ` Ludovic Courtès
2018-10-31 6:11 ` [bug#33215] [PATCH 07/11] gnu: Add clojure-instaparse Alex Vong
2018-10-31 6:11 ` [bug#33215] [PATCH 08/11] gnu: Add clojure-core-match Alex Vong
2018-10-31 6:12 ` [bug#33215] [PATCH 09/11] gnu: Add clojure-algo-generic Alex Vong
2018-10-31 6:13 ` [bug#33215] [PATCH 10/11] gnu: Add clojure-tools-macro Alex Vong
2018-10-31 6:14 ` [bug#33215] [PATCH 11/11] gnu: Add clojure-algo-monads Alex Vong
2018-11-19 12:53 ` bug#33215: [PATCH 00/11] build-system: Add 'clojure-build-system' Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvkbv2gg.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=33215@debbugs.gnu.org \
--cc=alexvong1995@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).