From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50480) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPE08-0005Qw-3D for guix-patches@gnu.org; Tue, 20 Nov 2018 16:56:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPE04-0002m4-0f for guix-patches@gnu.org; Tue, 20 Nov 2018 16:56:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:33253) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gPE02-0002kt-NO for guix-patches@gnu.org; Tue, 20 Nov 2018 16:56:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gPE02-0001sO-Gt for guix-patches@gnu.org; Tue, 20 Nov 2018 16:56:02 -0500 Subject: [bug#33215] [PATCH 05/11] guix: Add clojure-utils. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87muquhcw3.fsf@gmail.com> <871s86hck1.fsf@gmail.com> Date: Tue, 20 Nov 2018 22:55:27 +0100 In-Reply-To: <871s86hck1.fsf@gmail.com> (Alex Vong's message of "Wed, 31 Oct 2018 14:09:50 +0800") Message-ID: <87tvkbv2gg.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Alex Vong Cc: 33215@debbugs.gnu.org Hello! I=E2=80=99m late to the party but I think there are things worth discussing here. Danny, for non-trivial bits, in particular in the (guix =E2=80=A6) n= ame space, I think we should ping people to get more detailed review before merging. Alex Vong skribis: > From 857cce37325f01c26f79a6e15e33d7988ea4a0a2 Mon Sep 17 00:00:00 2001 > From: Alex Vong > Date: Sun, 14 Oct 2018 03:09:48 +0800 > Subject: [PATCH 05/11] guix: Add clojure-utils. > > * guix/build/clojure-utils.scm: New file. > * gnu/packages/lisp.scm (clojure)[arguments]: Use it. > * Makefile.am (MODULES): Add it. [...] > +(define-module (guix build clojure-utils) > + #:use-module (guix build utils) > + #:use-module (ice-9 ftw) > + #:use-module (ice-9 regex) > + #:use-module (srfi srfi-1) > + #:use-module (srfi srfi-26) > + #:export (%clojure-regex > + define-with-docs > + install-doc)) > + > +(define-syntax-rule (define-with-docs name docs val) > + "Create top-level variable named NAME with doc string DOCS and value V= AL." > + (begin (define name val) > + (set-object-property! name 'documentation docs))) This is not necessarily a bad idea, but in general I=E2=80=99m very much in favor of consistency: since we don=E2=80=99t use this anywhere else, I=E2= =80=99d rather not have it here either. We could discuss it separately, but IMO it shouldn=E2=80=99t be buried in a Clojure patch. Thus I=E2=80=99d be in favor of using the same style in this file as in the= rest of Guix. WDYT? Thanks, Ludo=E2=80=99.