unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Robert Smith <robertsmith@posteo.net>
Cc: 39331@debbugs.gnu.org
Subject: [bug#39331] [PATCH v2] gnu: Add emacs-persist and emacs-org-drill
Date: Sun, 02 Feb 2020 15:11:17 +0100	[thread overview]
Message-ID: <87tv499j0a.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20200129110724.11686-1-robertsmith@posteo.net> (Robert Smith's message of "Wed, 29 Jan 2020 12:07:24 +0100")

Hello,

Robert Smith <robertsmith@posteo.net> writes:

> * gnu/packages/emacs-xyz.scm (emacs-persist): New variable.
>   (emacs-org-drill): New variable.

Thank you!

Would you mind splitting this into two different patches?

> +    (synopsis "Persist Variables between Emacs Sessions")

I think titlecase is not warranted here:

  Persist variables between Emacs sessions

> +    (description
> +     "This package provides variables which persist across sessions.
> +Values are stored in a directory in `user-emacs-directory', using

@code{user-emacs-directory} may be more appropriate here.

> +    (propagated-inputs
> +     `(("emacs-seq" ,emacs-seq)
> +       ("emacs-org" ,emacs-org)
> +       ("emacs-persist" ,emacs-persist)))

Could you re-order inputs alphabetically?

> +    (home-page "https://gitlab.com/phillord/org-drill")
> +    (synopsis "Self-testing using spaced repetition")
> +    (description
> +    "Org-Drill is an extension for Org mode. Org-Drill uses a spaced

    Org Drill is an....

> +repetition algorithm to conduct interactive drill sessions, using org files as

... using Org files as...

> +sources of facts to be memorised. Each topic is treated as a flash card. The
> +material to be remembered is presented to the student in random order. The
> +student rates his or her recall of each item, and this information is used to
> +schedule the item for later revision.")

You need to put two spaces after full stops.

Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2020-02-02 14:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-28 22:19 [bug#39331] [PATCH] gnu: Add emacs-persist and emacs-org-drill Robert Smith
2020-01-29 11:07 ` [bug#39331] [PATCH v2] " Robert Smith
2020-02-02 14:11   ` Nicolas Goaziou [this message]
2020-02-14 16:49     ` Robert Smith
     [not found] <C0M1HHN1UUKB.21BGBA4EOUL7V@amber>
2020-02-14 16:59 ` [bug#39331] [PATCH v3] gnu: Add emacs-persist Robert Smith
2020-02-17  9:18   ` Nicolas Goaziou
2020-03-07 23:50     ` bug#39331: " Robert Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tv499j0a.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=39331@debbugs.gnu.org \
    --cc=robertsmith@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).