From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:58143)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iyFyl-0005XN-Mj
 for guix-patches@gnu.org; Sun, 02 Feb 2020 09:12:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iyFyk-0005ra-Ge
 for guix-patches@gnu.org; Sun, 02 Feb 2020 09:12:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:33678)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1iyFyk-0005qT-D6
 for guix-patches@gnu.org; Sun, 02 Feb 2020 09:12:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1iyFyk-0002Oo-65
 for guix-patches@gnu.org; Sun, 02 Feb 2020 09:12:02 -0500
Subject: [bug#39331] [PATCH v2] gnu: Add emacs-persist and emacs-org-drill
Resent-Message-ID: <handler.39331.B39331.15806526909175@debbugs.gnu.org>
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
References: <20200128221944.6791-1-robertsmith@posteo.net>
 <20200129110724.11686-1-robertsmith@posteo.net>
Date: Sun, 02 Feb 2020 15:11:17 +0100
In-Reply-To: <20200129110724.11686-1-robertsmith@posteo.net> (Robert Smith's
 message of "Wed, 29 Jan 2020 12:07:24 +0100")
Message-ID: <87tv499j0a.fsf@nicolasgoaziou.fr>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Robert Smith <robertsmith@posteo.net>
Cc: 39331@debbugs.gnu.org

Hello,

Robert Smith <robertsmith@posteo.net> writes:

> * gnu/packages/emacs-xyz.scm (emacs-persist): New variable.
>   (emacs-org-drill): New variable.

Thank you!

Would you mind splitting this into two different patches?

> +    (synopsis "Persist Variables between Emacs Sessions")

I think titlecase is not warranted here:

  Persist variables between Emacs sessions

> +    (description
> +     "This package provides variables which persist across sessions.
> +Values are stored in a directory in `user-emacs-directory', using

@code{user-emacs-directory} may be more appropriate here.

> +    (propagated-inputs
> +     `(("emacs-seq" ,emacs-seq)
> +       ("emacs-org" ,emacs-org)
> +       ("emacs-persist" ,emacs-persist)))

Could you re-order inputs alphabetically?

> +    (home-page "https://gitlab.com/phillord/org-drill")
> +    (synopsis "Self-testing using spaced repetition")
> +    (description
> +    "Org-Drill is an extension for Org mode. Org-Drill uses a spaced

    Org Drill is an....

> +repetition algorithm to conduct interactive drill sessions, using org files as

... using Org files as...

> +sources of facts to be memorised. Each topic is treated as a flash card. The
> +material to be remembered is presented to the student in random order. The
> +student rates his or her recall of each item, and this information is used to
> +schedule the item for later revision.")

You need to put two spaces after full stops.

Regards,

-- 
Nicolas Goaziou