unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#57726] [PATCH] gnu: Add java-eclipse-sisu-maven-plugin.
@ 2022-09-11  9:11 Artyom V. Poptsov
  2022-09-11 10:05 ` Julien Lepiller
  0 siblings, 1 reply; 5+ messages in thread
From: Artyom V. Poptsov @ 2022-09-11  9:11 UTC (permalink / raw)
  To: 57726


[-- Attachment #1.1: Type: text/plain, Size: 62 bytes --]

Hello,

this patch adds "java-eclipse-sisu-maven-plugin". [1]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-Add-java-eclipse-sisu-maven-plugin.patch --]
[-- Type: text/x-diff, Size: 2450 bytes --]

From a39872e7029433fe0ba0198dbfdf7182015a74fc Mon Sep 17 00:00:00 2001
From: "Artyom V. Poptsov" <poptsov.artyom@gmail.com>
Date: Sun, 11 Sep 2022 12:02:27 +0300
Subject: [PATCH] gnu: Add java-eclipse-sisu-maven-plugin.

* gnu/packages/java.scm (java-eclipse-sisu-maven-plugin): New variable.
---
 gnu/packages/java.scm | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index 45c3b423f0..0445e45681 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -13400,6 +13400,44 @@ (define-public java-eclipse-sisu-inject
 OSGi Service Registry is a goal of this project.")
     (license license:epl1.0)))
 
+(define-public java-eclipse-sisu-maven-plugin
+  (package
+    (name "java-eclipse-sisu-maven-plugin")
+    (version "0.3.5")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/eclipse/sisu.mojos/")
+                    (commit (string-append "releases/" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "00hb7v6hz8jg0mgkj3cl0nmqz49za4k2a0rbjr4gdhy2m7f34sq3"))))
+    (build-system ant-build-system)
+    (arguments
+     (list #:jar-name "eclipse-sisu-maven-plugin.jar"
+           #:source-dir "src"
+           #:tests? #f ;no tests
+           #:phases #~(modify-phases %standard-phases
+                        (replace 'install
+                          (install-from-pom "pom.xml")))))
+    (propagated-inputs (list java-sonatype-oss-parent-pom-9))
+    (inputs (list maven-artifact
+                  maven-plugin-api
+                  maven-plugin-annotations
+                  maven-core
+                  maven-common-artifact-filters
+                  java-slf4j-nop
+                  java-eclipse-sisu-inject
+                  java-plexus-utils
+                  java-plexus-build-api
+                  java-slf4j-api))
+    (home-page "https://www.eclipse.org/sisu/")
+    (synopsis "Maven plugin that generates annotation indexes for Sisu")
+    (description "Maven plugin that generates annotation indexes for Sisu to
+avoid classpath scanning at runtime.")
+    (license license:epl1.0)))
+
 (define java-sisu-inject-parent-pom
   (package
     (inherit java-eclipse-sisu-inject)
-- 
2.34.1


[-- Attachment #1.3: Type: text/plain, Size: 383 bytes --]


The patch requires "slf4j-nop" package:
  https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57724

Thanks,
- Artyom

References:
1. https://github.com/eclipse/sisu.mojos

-- 
Artyom "avp" Poptsov <poptsov.artyom@gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 519 bytes --]

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#57726] [PATCH] gnu: Add java-eclipse-sisu-maven-plugin.
  2022-09-11  9:11 [bug#57726] [PATCH] gnu: Add java-eclipse-sisu-maven-plugin Artyom V. Poptsov
@ 2022-09-11 10:05 ` Julien Lepiller
  2022-09-16 21:28   ` Artyom V. Poptsov
  0 siblings, 1 reply; 5+ messages in thread
From: Julien Lepiller @ 2022-09-11 10:05 UTC (permalink / raw)
  To: Artyom V. Poptsov, 57726

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

The name implies this is a plugin for maven. The way you build it, maven will not be able to use it because it's missing some metadata.

You can use generate-plugin.xml to generate the required file. The parser might not work properly, I'll have a look if it doesn't work, but that might take some time.

Le 11 septembre 2022 11:11:23 GMT+02:00, "Artyom V. Poptsov" <poptsov.artyom@gmail.com> a écrit :
>Hello,
>
>this patch adds "java-eclipse-sisu-maven-plugin". [1]

[-- Attachment #2: Type: text/html, Size: 744 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#57726] [PATCH] gnu: Add java-eclipse-sisu-maven-plugin.
  2022-09-11 10:05 ` Julien Lepiller
@ 2022-09-16 21:28   ` Artyom V. Poptsov
  2022-09-24 13:52     ` Ludovic Courtès
  0 siblings, 1 reply; 5+ messages in thread
From: Artyom V. Poptsov @ 2022-09-16 21:28 UTC (permalink / raw)
  To: Julien Lepiller; +Cc: 57726


[-- Attachment #1.1: Type: text/plain, Size: 579 bytes --]

Hello Julien.

> The name implies this is a plugin for maven. The way you build it,
> maven will not be able to use it because it's missing some metadata.

Okay.  I moved the package to (gnu packages maven) as it seems to be
the more appropriate place for Maven plugins indeed.

> You can use generate-plugin.xml to generate the required file. The
> parser might not work properly, I'll have a look if it doesn't work, but
> that might take some time.

Thanks for the hint, I modified the patch so now the package uses
"generate-plugin.xml".

Please find the new patch attached.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-Add-maven-sisu-plugin.patch --]
[-- Type: text/x-diff, Size: 3085 bytes --]

From 14b58121576e154b4bf96564dffb9fd09f5e0b81 Mon Sep 17 00:00:00 2001
From: "Artyom V. Poptsov" <poptsov.artyom@gmail.com>
Date: Sat, 17 Sep 2022 00:23:33 +0300
Subject: [PATCH] gnu: Add maven-sisu-plugin.

* gnu/packages/maven.scm (maven-sisu-plugin): New variable.
---
 gnu/packages/maven.scm | 45 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/gnu/packages/maven.scm b/gnu/packages/maven.scm
index 28ec4eb9a8..b897c6ed34 100644
--- a/gnu/packages/maven.scm
+++ b/gnu/packages/maven.scm
@@ -27,6 +27,7 @@ (define-module (gnu packages maven)
   #:use-module (guix git-download)
   #:use-module (guix utils)
   #:use-module (guix build-system ant)
+  #:use-module (guix gexp)
   #:use-module (gnu packages)
   #:use-module (gnu packages base)
   #:use-module (gnu packages compression)
@@ -3012,6 +3013,50 @@ (define-public maven-enforcer-plugin
            maven-plugin-annotations
            maven-enforcer-parent-pom))))
 
+(define-public maven-sisu-plugin
+  (package
+    (name "maven-sisu-plugin")
+    (version "0.3.5")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/eclipse/sisu.mojos/")
+                    (commit (string-append "releases/" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "00hb7v6hz8jg0mgkj3cl0nmqz49za4k2a0rbjr4gdhy2m7f34sq3"))))
+    (build-system ant-build-system)
+    (arguments
+     (list #:jar-name "maven-sisu-plugin.jar"
+           #:source-dir "src"
+           #:tests? #f ;no tests
+           #:phases #~(modify-phases %standard-phases
+                        (add-before 'build 'generate-plugin.xml
+                          (generate-plugin.xml "pom.xml" "sisu"
+                           "src/main/java/org/eclipse/sisu/mojos/"
+                           (list (list "IndexMojo.java")
+                                 (list "MainIndexMojo.java")
+                                 (list "TestIndexMojo.java"))))
+                        (replace 'install
+                          (install-from-pom "pom.xml")))))
+    (propagated-inputs (list java-sonatype-oss-parent-pom-9))
+    (inputs (list maven-artifact
+                  maven-plugin-api
+                  maven-plugin-annotations
+                  maven-core
+                  maven-common-artifact-filters
+                  java-slf4j-nop
+                  java-eclipse-sisu-inject
+                  java-plexus-utils
+                  java-plexus-build-api
+                  java-slf4j-api))
+    (home-page "https://www.eclipse.org/sisu/")
+    (synopsis "Maven plugin that generates annotation indexes for Sisu")
+    (description "Maven plugin that generates annotation indexes for Sisu to
+avoid classpath scanning at runtime.")
+    (license license:epl1.0)))
+
 (define-public maven-artifact-transfer
   (package
     (name "maven-artifact-transfer")
-- 
2.34.1


[-- Attachment #1.3: Type: text/plain, Size: 219 bytes --]


- Artyom

-- 
Artyom "avp" Poptsov <poptsov.artyom@gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 519 bytes --]

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#57726] [PATCH] gnu: Add java-eclipse-sisu-maven-plugin.
  2022-09-16 21:28   ` Artyom V. Poptsov
@ 2022-09-24 13:52     ` Ludovic Courtès
  2022-09-24 17:07       ` bug#57726: " Julien Lepiller
  0 siblings, 1 reply; 5+ messages in thread
From: Ludovic Courtès @ 2022-09-24 13:52 UTC (permalink / raw)
  To: Artyom V. Poptsov; +Cc: Julien Lepiller, 57726

Hi!

Julien, WDYT?  :-)

Ludo’.

"Artyom V. Poptsov" <poptsov.artyom@gmail.com> skribis:

> Hello Julien.
>
>> The name implies this is a plugin for maven. The way you build it,
>> maven will not be able to use it because it's missing some metadata.
>
> Okay.  I moved the package to (gnu packages maven) as it seems to be
> the more appropriate place for Maven plugins indeed.
>
>> You can use generate-plugin.xml to generate the required file. The
>> parser might not work properly, I'll have a look if it doesn't work, but
>> that might take some time.
>
> Thanks for the hint, I modified the patch so now the package uses
> "generate-plugin.xml".
>
> Please find the new patch attached.
>
>
>
> - Artyom




^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#57726: [PATCH] gnu: Add java-eclipse-sisu-maven-plugin.
  2022-09-24 13:52     ` Ludovic Courtès
@ 2022-09-24 17:07       ` Julien Lepiller
  0 siblings, 0 replies; 5+ messages in thread
From: Julien Lepiller @ 2022-09-24 17:07 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: Artyom V. Poptsov, 57726-done

Le Sat, 24 Sep 2022 15:52:56 +0200,
Ludovic Courtès <ludo@gnu.org> a écrit :

> Hi!
> 
> Julien, WDYT?  :-)
> 

Looks like I didn't receive the reply. The patch is now pushed to
master as fc07082fe3d750c85282c4aa57d01a36ebe9296b, thanks!

Again, I noticed qa.guix.gnu.org doing its work :)




^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-09-24 17:08 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-11  9:11 [bug#57726] [PATCH] gnu: Add java-eclipse-sisu-maven-plugin Artyom V. Poptsov
2022-09-11 10:05 ` Julien Lepiller
2022-09-16 21:28   ` Artyom V. Poptsov
2022-09-24 13:52     ` Ludovic Courtès
2022-09-24 17:07       ` bug#57726: " Julien Lepiller

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).