From: "Ludovic Courtès" <ludo@gnu.org>
To: Lukasz Olszewski <dev@lukaszolszewski.info>
Cc: 57590@debbugs.gnu.org
Subject: [bug#57590] [PATCH] Adding libldm: Manager for Windows dynamic disks including software RAID. It creates device mapper entries for dynamic disks allowing them to be mounted.
Date: Mon, 17 Oct 2022 10:03:49 +0200 [thread overview]
Message-ID: <87tu42ho62.fsf@gnu.org> (raw)
In-Reply-To: <CACwB4R5Nype6=UppoXOZZO234AM5CjA=Opad4hyJNM0WChqKcQ@mail.gmail.com> (Lukasz Olszewski's message of "Sun, 4 Sep 2022 23:42:55 +0200")
Hi Lukasz,
Apologies for the delay!
I think the patch series is close to being ready; we’ll need a few
changes before we’re done.
Lukasz Olszewski <dev@lukaszolszewski.info> skribis:
> ---
> gnu/packages/libldm.scm | 70 +++++++++++++++++++++++++++++++++++++++++
> gnu/services/libldm.scm | 47 +++++++++++++++++++++++++++
Please make one patch adding the package, and another one adding the
service.
In each patch, please make sure to add the new file to gnu/local.mk (you
can check the Git history for examples.)
> +++ b/gnu/packages/libldm.scm
> @@ -0,0 +1,70 @@
> +(define-module (gnu packages libldm)
We’ll need the license/copyright header as you noted.
> + (arguments
> + '(#:tests? #f
Please add a comment explaining why tests are skipped. That should be a
last resort.
> + #:parallel-build? #t
This is unnecessary.
> + #:phases (modify-phases %standard-phases
> + (add-before 'configure 'set-env
> + (lambda _
> + (setenv "CONFIG_SHELL"
> + (which "")) #t))
I don’t think this can work because (which "") returns #f but ‘setenv’
expects a string.
> + (replace 'bootstrap
> + (lambda _
> + (invoke "autoreconf" "-fiv"))))))
Is it necessary? The default ‘bootstrap’ phase does something similar.
> + (license license:gpl3)))
This should be ‘license:gpl3+’ because source file headers carry the “or
any later version” wording.
> +(define-record-type* <libldm-configuration>
> + libldm-configuration
> + make-libldm-configuration
> + libldm-configuration?
> + (package
> + libldm-configuration-package
> + (default libldm))
> + (action libldm-configuration-action
> + (default '("create" "all"))))
Indentation is off here (I noticed that ‘guix style’ got it wrong so I’m
fixing it now…).
> +(define (libldm-shepherd-service config)
> + "Return a <shepherd-service> for libldm with CONFIG"
> + (let* ((libldm (libldm-configuration-package config))
> + (action (libldm-configuration-action config)))
> + (list (shepherd-service (documentation
> + "Run ldmtool to create Windows dynamic
> disc device nodes at startup.")
Maybe s/disc/disk/ throughout for consistency?
> +(define libldm-service-type
> + (service-type (name 'libldm)
> + (extensions (list (service-extension
> + shepherd-root-service-type
> + libldm-shepherd-service)))
> + (default-value (libldm-configuration))
> + (description
> + "Run ldmtool to create device nodes for Windows
> dynamic discs so they can be mounted")))
Please add a period at the end, and write @command{ldmtool}.
One last thing: could you add documentation for the service in
doc/guix.texi, maybe under “Virtualization” or in some new section?
Please include a paragraph giving some context and an example.
Could you send updated patches?
Thanks in advance!
Ludo’.
next prev parent reply other threads:[~2022-10-17 8:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-04 21:42 [bug#57590] [PATCH] Adding libldm: Manager for Windows dynamic disks including software RAID. It creates device mapper entries for dynamic disks allowing them to be mounted Lukasz Olszewski
2022-09-10 22:02 ` Lukasz Olszewski
2022-10-17 8:03 ` Ludovic Courtès [this message]
2022-10-17 11:12 ` Lukasz Olszewski
2022-10-18 15:20 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu42ho62.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=57590@debbugs.gnu.org \
--cc=dev@lukaszolszewski.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).