From: "Ludovic Courtès" <ludo@gnu.org>
To: Lukasz Olszewski <dev@lukaszolszewski.info>
Cc: 57590@debbugs.gnu.org
Subject: [bug#57590] [PATCH] Adding libldm: Manager for Windows dynamic disks including software RAID. It creates device mapper entries for dynamic disks allowing them to be mounted.
Date: Tue, 18 Oct 2022 17:20:15 +0200 [thread overview]
Message-ID: <878rldma4w.fsf@gnu.org> (raw)
In-Reply-To: <CACwB4R4RUGdOCmo=7tsMAF-2Kj_tVZ5sFSn1tSv_mESKUfJ7hg@mail.gmail.com> (Lukasz Olszewski's message of "Mon, 17 Oct 2022 13:12:13 +0200")
Hi,
Lukasz Olszewski <dev@lukaszolszewski.info> skribis:
>> > +++ b/gnu/packages/libldm.scm
>> > @@ -0,0 +1,70 @@
>> > +(define-module (gnu packages libldm)
>>
>> We’ll need the license/copyright header as you noted.
>>
>
> I've posted a later patch that included those, but it was posted as a patch
> on top of a patch so perhaps it wasn't well visible. I'll integrate it in
> the next version.
I did see it (thanks!). It would be great though if you could send a
single “v2” patch that includes everything.
>> > + #:parallel-build? #t
>>
>> This is unnecessary.
>>
>
> Are parallel builds enabled by default?
Yes, that’s why.
>> > + (replace 'bootstrap
>> > + (lambda _
>> > + (invoke "autoreconf" "-fiv"))))))
>>
>> Is it necessary? The default ‘bootstrap’ phase does something similar.
>>
>
> I've copied this phase from another package. If I remember correctly the
> configure phase failed without. I'll have to test again to check.
Yes please.
Thanks,
Ludo’.
prev parent reply other threads:[~2022-10-18 15:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-04 21:42 [bug#57590] [PATCH] Adding libldm: Manager for Windows dynamic disks including software RAID. It creates device mapper entries for dynamic disks allowing them to be mounted Lukasz Olszewski
2022-09-10 22:02 ` Lukasz Olszewski
2022-10-17 8:03 ` Ludovic Courtès
2022-10-17 11:12 ` Lukasz Olszewski
2022-10-18 15:20 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rldma4w.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=57590@debbugs.gnu.org \
--cc=dev@lukaszolszewski.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).