From: zimoun <zimon.toutoune@gmail.com>
To: 59754@debbugs.gnu.org
Cc: ludo@gnu.org, Antero Mejr <antero@mailbox.org>
Subject: [bug#59754] [PATCH] scripts: repl: Add --interactive and --list-types flags.
Date: Fri, 02 Dec 2022 16:46:56 +0100 [thread overview]
Message-ID: <87tu2dreof.fsf@gmail.com> (raw)
In-Reply-To: <20221202025641.9318-1-antero@mailbox.org>
Hi,
Thanks, nice!
On Fri, 02 Dec 2022 at 02:56, Antero Mejr via Guix-patches via <guix-patches@gnu.org> wrote:
> * guix/scripts/repl.scm (guix-repl): Honor -i, --interactive flag.
> (%options): Add -i/--interactive and --l/--list-types.
-^
Typo
The patch LGTM, minor three comments.
1. I would not use the shortkey -l; only the long one.
2. I would move --list-types right before -t/--type
--8<---------------cut here---------------start------------->8---
--list-types display REPL types and exit
-t, --type=TYPE start a REPL of the given TYPE
--listen=ENDPOINT listen to ENDPOINT instead of standard input
-q inhibit loading of ~/.guile
-i, --interactive launch REPL after evaluating FILE
-L, --load-path=DIR prepend DIR to the package module search path
-h, --help display this help and exit
-V, --version display version information and exit
--8<---------------cut here---------------end--------------->8---
3. I would split the addition of --list-types and --interactive in two
separated commits. But for each option, I would also change the manual
with the same commit. Else, please squash this submission. :-)
Cheers,
simon
next prev parent reply other threads:[~2022-12-02 16:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 2:56 [bug#59754] [PATCH] scripts: repl: Add --interactive and --list-types flags Antero Mejr via Guix-patches via
2022-12-02 3:35 ` [bug#59754] [PATCH] doc: Add new flag information to REPL section Antero Mejr via Guix-patches via
2022-12-02 15:46 ` zimoun [this message]
2022-12-03 1:10 ` [bug#59754] [PATCH] scripts: repl: Add --interactive and --list-types flags Antero Mejr via Guix-patches via
2022-12-03 1:09 ` [bug#59754] [PATCH 1/2] scripts: repl: Add --list-types flag Antero Mejr via Guix-patches via
2022-12-03 1:09 ` [bug#59754] [PATCH 2/2] scripts: repl: Add -i, --interactive flag Antero Mejr via Guix-patches via
2023-01-16 14:03 ` bug#59754: [PATCH] scripts: repl: Add --interactive and --list-types flags Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu2dreof.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=59754@debbugs.gnu.org \
--cc=antero@mailbox.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).