From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id wLUwO2YjimMMvAAAbAwnHQ (envelope-from ) for ; Fri, 02 Dec 2022 17:10:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id eA1UOmYjimOTAgAAG6o9tA (envelope-from ) for ; Fri, 02 Dec 2022 17:10:14 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 99F4324815 for ; Fri, 2 Dec 2022 17:10:14 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p18c2-0006xC-Gs; Fri, 02 Dec 2022 11:10:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p18c0-0006ve-Gj for guix-patches@gnu.org; Fri, 02 Dec 2022 11:10:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p18c0-0003VK-7v for guix-patches@gnu.org; Fri, 02 Dec 2022 11:10:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p18c0-0006za-3i for guix-patches@gnu.org; Fri, 02 Dec 2022 11:10:04 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59754] [PATCH] scripts: repl: Add --interactive and --list-types flags. Resent-From: zimoun Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 02 Dec 2022 16:10:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59754 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 59754@debbugs.gnu.org Cc: ludo@gnu.org, Antero Mejr X-Debbugs-Original-To: Antero Mejr via Guix-patches via , 59754@debbugs.gnu.org Received: via spool by 59754-submit@debbugs.gnu.org id=B59754.166999739026819 (code B ref 59754); Fri, 02 Dec 2022 16:10:04 +0000 Received: (at 59754) by debbugs.gnu.org; 2 Dec 2022 16:09:50 +0000 Received: from localhost ([127.0.0.1]:47503 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p18bm-0006yQ-CG for submit@debbugs.gnu.org; Fri, 02 Dec 2022 11:09:50 -0500 Received: from mail-wm1-f53.google.com ([209.85.128.53]:37526) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p18bj-0006xo-CZ for 59754@debbugs.gnu.org; Fri, 02 Dec 2022 11:09:49 -0500 Received: by mail-wm1-f53.google.com with SMTP id ay14-20020a05600c1e0e00b003cf6ab34b61so6807308wmb.2 for <59754@debbugs.gnu.org>; Fri, 02 Dec 2022 08:09:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=AtR384xRAGFdzUewIzEBiXkOlhPonD5904Dmg/CXu3k=; b=quuxigITXmeJyCOH4I5GI9HWWt1iHiaTaCXhvr0ORNBnpY9kNhBX55SGJ4pAjPMED8 V0KqSptucfQYiCWJfwQnS3qPJ92b09OfHoeGaawVIY+T6b3uyKPI3QJ84P7CB8n4wN+P zOlj7wp6PvrvygnV2FmkKWNBQKVWnozIxJoomUAjHR4MOlCkMz46oz+LxxQsymkbLNu8 BURtWmZ8jRB0XwNLf3/EjfPevQMkLVrUwO0D79umGC4UKBoof2YTVKRvujM1HhATr8Ep aEKvHLR99eOed/uLMNsNtOVx8SuUgmSVgoar5oLE0l8bPZiMGcQeB6Y610hY2+Yy4l/D YVjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AtR384xRAGFdzUewIzEBiXkOlhPonD5904Dmg/CXu3k=; b=iI4xfumOnISLzA8bfv/0ZtRgGsd8WfXnl2rmfG9n4H/oUCiDZ6aWEs/QqrjDnLOoHK AgVUEMcb+07jY70fHCmge1qHCML9OxUN8rrE6bz+PyrmQwGFrSWtZG4XdAk9DmC6ibuv 6QvpoE4EDQZ0/KRzJuLOvHVJouX/hMsXro5tZZAT8l9E7nSx3ke+YkNuke2B7+B5Djbd jNc2bqnxJ3MAyAzKnkWc+zxy4+iKyEUdxDvJP0Qk+PGOpnxDKhWnmtNfhcd0/6ZrFuz2 oIWzk+aLiCOiU8CRojnyNEhwgyWypjk/b1SMgnQ0b+a46sNfSI5EjjMFtlFUI6cq7iDf 7K7g== X-Gm-Message-State: ANoB5plLSV3B61mfOdN75WnUfcq+Fwf0Qj9p+wkWsURTqIa8sBtq7W42 vZrJyhTTHGiIkd40QPQ5SMY= X-Google-Smtp-Source: AA0mqf5XREtbGSKSVRabKfTDiYUnzSX+RJ/615myRynHRs6rjq17BR5Hx0HeZlK5McHyFNYFFabRFw== X-Received: by 2002:a05:600c:3587:b0:3cf:a9c2:2b04 with SMTP id p7-20020a05600c358700b003cfa9c22b04mr52248112wmq.152.1669997381570; Fri, 02 Dec 2022 08:09:41 -0800 (PST) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id o12-20020a5d670c000000b002424b695f7esm881336wru.46.2022.12.02.08.09.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Dec 2022 08:09:41 -0800 (PST) From: zimoun In-Reply-To: <20221202025641.9318-1-antero@mailbox.org> References: <20221202025641.9318-1-antero@mailbox.org> Date: Fri, 02 Dec 2022 16:46:56 +0100 Message-ID: <87tu2dreof.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1669997414; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=AtR384xRAGFdzUewIzEBiXkOlhPonD5904Dmg/CXu3k=; b=aLtxiDdDMT9zKHBLgKhRHYPTuC7OlkTLYF+MfhQvHlJueEdOlZ/cBA88BkDAHcPwTnwhhU SeOFvFxsCJs2zDNNxy9CR61UZVder1fIpInKEODOmJp2UdH5HN9lva4gK5G5OPt529uthK j/otFy9QDVceqRCkXnhN7PiPacvFqlqX1zzwf/IlQnhKCFNwRzXXg7TaI90VWF3KvsmlPf Bsb652O1aKUbXtIhxlze+QcE5pWXMP2HzypbYzIDsRHf2QnyjrKjlKCysWYycZDpJlYzyP dN3kX4PUeZjzdUmLGJX9d7SvDHBrynI9A6IeVuwOtKE4Ehv6RrKVj4vBLETSYg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1669997414; a=rsa-sha256; cv=none; b=KwLsxqtFHJlwrh/O10Ml7x98iuVr77OvErxna+eh+HfoXnwlBfZgq1dn6JDMODgXf+1aSL MtX4zCOKevT+YW53olewNeblFUsvDrUoisj7XuX19rPZP1/lHxLLXQ/97wK66pp1nM7GV4 /czXurD+El33+ofgy3rGE+ab5kT7B/k+r0EEjEaWyMPlXGhUMpvOIM/9PkvJR9aJXoryuM is4yiAcp1f+JZBh7RBerptib/K+heCnbwPiKoxq38T27qvFcSLR4tCgUncTfNaJZDokD6i mJQlCoWKpLuEtRiIxrIjoCfIzTukoA7jbnit9dU3BOaX/O6naxdSxVY7FrokoA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=quuxigIT; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.53 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=quuxigIT; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 99F4324815 X-Spam-Score: 7.53 X-Migadu-Scanner: scn1.migadu.com X-TUID: RsrNqEqq9Rae Hi, Thanks, nice! On Fri, 02 Dec 2022 at 02:56, Antero Mejr via Guix-patches via wrote: > * guix/scripts/repl.scm (guix-repl): Honor -i, --interactive flag. > (%options): Add -i/--interactive and --l/--list-types. -^ Typo The patch LGTM, minor three comments. 1. I would not use the shortkey -l; only the long one. 2. I would move --list-types right before -t/--type --8<---------------cut here---------------start------------->8--- --list-types display REPL types and exit -t, --type=TYPE start a REPL of the given TYPE --listen=ENDPOINT listen to ENDPOINT instead of standard input -q inhibit loading of ~/.guile -i, --interactive launch REPL after evaluating FILE -L, --load-path=DIR prepend DIR to the package module search path -h, --help display this help and exit -V, --version display version information and exit --8<---------------cut here---------------end--------------->8--- 3. I would split the addition of --list-types and --interactive in two separated commits. But for each option, I would also change the manual with the same commit. Else, please squash this submission. :-) Cheers, simon