bug#45591: environment: gracefully handle unsupported system.

[Maxim Cournoyer <maxim.cournoyer@gmail.com>]

Hi,

Ludovic Courtès <ludo@gnu.org> writes:

> Hi,
>
> guy fleury iteriteka <gfleury@disroot.org> skribis:
>
>> diff --git a/guix/scripts/environment.scm b/guix/scripts/environment.scm
>> index e435bf0..40af012 100644
>> --- a/guix/scripts/environment.scm
>> +++ b/guix/scripts/environment.scm
>> @@ -719,6 +719,10 @@ message if any test fails."
>>             (mappings   (pick-all opts 'file-system-mapping))
>>             (white-list (pick-all opts 'inherit-regexp)))
>>  
>> +      (when (not (member system '("armhf-linux" "aarch64-linux"
>> +                                  "i686-linux" "x86_64-linux" "i586-gnu")))
>> +        (leave (G_ "guix does not support ~A system~%") system))
>
> The system list should not be hardcoded (there’s already such a list in
> (guix packages)).
>
> Currently the error one gets is:
>
>   $ guix environment -s does-not-exist --ad-hoc coreutils 
>   guix environment: error: could not find bootstrap binary 'tar' for system 'does-not-exist'
>
> I suppose that’s what you intended to improve, right?

Thanks to the recent work of Mathieu, we now get:

guix environment: error: 'does-not-exist' is not a supported system
hint: Try `--list-systems' to view available system types.

Closing.

-- 
Thanks,
Maxim