unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: guy fleury iteriteka <gfleury@disroot.org>
Cc: 45591@debbugs.gnu.org
Subject: [bug#45591] environment: gracefully handle unsupported system.
Date: Wed, 13 Jan 2021 15:37:53 +0100	[thread overview]
Message-ID: <87lfcwaon2.fsf@gnu.org> (raw)
In-Reply-To: <87v9chx71n.fsf@disroot.org> (guy fleury iteriteka's message of "Fri, 01 Jan 2021 12:53:08 +0200")

Hi,

guy fleury iteriteka <gfleury@disroot.org> skribis:

> diff --git a/guix/scripts/environment.scm b/guix/scripts/environment.scm
> index e435bf0..40af012 100644
> --- a/guix/scripts/environment.scm
> +++ b/guix/scripts/environment.scm
> @@ -719,6 +719,10 @@ message if any test fails."
>             (mappings   (pick-all opts 'file-system-mapping))
>             (white-list (pick-all opts 'inherit-regexp)))
>  
> +      (when (not (member system '("armhf-linux" "aarch64-linux"
> +                                  "i686-linux" "x86_64-linux" "i586-gnu")))
> +        (leave (G_ "guix does not support ~A system~%") system))

The system list should not be hardcoded (there’s already such a list in
(guix packages)).

Currently the error one gets is:

  $ guix environment -s does-not-exist --ad-hoc coreutils 
  guix environment: error: could not find bootstrap binary 'tar' for system 'does-not-exist'

I suppose that’s what you intended to improve, right?

Ludo’.




  reply	other threads:[~2021-01-13 14:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-01 10:53 [bug#45591] environment: gracefully handle unsupported system guy fleury iteriteka via Guix-patches via
2021-01-13 14:37 ` Ludovic Courtès [this message]
2023-01-16 18:10   ` bug#45591: " Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfcwaon2.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=45591@debbugs.gnu.org \
    --cc=gfleury@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).