From: ludo@gnu.org (Ludovic Courtès)
To: Eric Bavier <ericbavier@centurylink.net>
Cc: 29271@debbugs.gnu.org, Chris Marusich <cmmarusich@gmail.com>,
myglc2@gmail.com
Subject: [bug#29271] [PATCH 1/1] doc: Split the "Substitutes" section into subsections.
Date: Mon, 20 Nov 2017 23:40:53 +0100 [thread overview]
Message-ID: <87shd8y3nu.fsf@gnu.org> (raw)
In-Reply-To: <20171112131725.7dbee7aa@centurylink.net> (Eric Bavier's message of "Sun, 12 Nov 2017 13:17:25 -0600")
Hello!
Eric Bavier <ericbavier@centurylink.net> skribis:
> On Sun, 12 Nov 2017 15:36:44 -0500
> Leo Famulari <leo@famulari.name> wrote:
>
>> On Sun, Nov 12, 2017 at 03:05:58AM -0800, Chris Marusich wrote:
>> > +@anchor{fallback-option}
>> > @item --fallback
>> > -When substituting a pre-built binary fails, fall back to building
>> > -packages locally.
>> > +Attempt to build locally instead of issuing an error when substitutes
>> > +are enabled and a substitute is available, but the substitution attempt
>> > +fails (@pxref{Substitution Failure}).
>>
>> I was able to read this smaller change. I think the new sentence is too
>> byzantine. I know what --fallback does but I found this sentence hard to
>> understand.
>
> Same here.
[...]
> IMHO, the original text is just fine, and succinctly conveys the
> origin of the option name. Perhaps just add the cross reference.
I agree, but I’m biased. ;-)
Apart from that, the rest LGTM. I have one minor request:
> +* Hydra:: One particular source of substitutes.
I would call this “Official Substitute Server” or something like that,
and not mention Hydra (as a proper noun) since we’re not defining it,
and since the server won’t run Hydra forever.
With these two changes, I think you can push.
Thanks for improving the manual!
Ludo’.
next prev parent reply other threads:[~2017-11-20 22:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-12 11:02 [bug#29271] [PATCH 0/1] Improve the "Substitutes" documentation Chris Marusich
2017-11-12 11:05 ` [bug#29271] [PATCH 1/1] doc: Split the "Substitutes" section into subsections Chris Marusich
2017-11-12 13:56 ` Jan Nieuwenhuizen
2017-11-12 20:25 ` Leo Famulari
2017-11-13 14:37 ` myglc2
2017-11-15 5:21 ` Chris Marusich
2017-11-15 13:31 ` myglc2
2017-11-12 20:36 ` Leo Famulari
2017-11-12 19:17 ` Eric Bavier
2017-11-20 22:40 ` Ludovic Courtès [this message]
2017-11-13 17:27 ` myglc2
2017-11-12 11:21 ` [bug#29271] [PATCH 0/1] Improve the "Substitutes" documentation Adonay Felipe Nogueira
2017-11-22 4:29 ` bug#29271: Status: " Chris Marusich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shd8y3nu.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=29271@debbugs.gnu.org \
--cc=cmmarusich@gmail.com \
--cc=ericbavier@centurylink.net \
--cc=myglc2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).