From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59280)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eGukT-0004ca-Pd
	for guix-patches@gnu.org; Mon, 20 Nov 2017 17:41:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eGukQ-00055e-KX
	for guix-patches@gnu.org; Mon, 20 Nov 2017 17:41:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:40935)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eGukQ-00055S-Gt
	for guix-patches@gnu.org; Mon, 20 Nov 2017 17:41:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eGukQ-0002sg-4O
	for guix-patches@gnu.org; Mon, 20 Nov 2017 17:41:02 -0500
Subject: [bug#29271] [PATCH 1/1] doc: Split the "Substitutes" section into
	subsections.
Resent-Message-ID: <handler.29271.B29271.151121765711055@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20171112110233.1384-1-cmmarusich@gmail.com>
	<20171112110558.1447-1-cmmarusich@gmail.com>
	<20171112203644.GB10629@jasmine.lan>
	<20171112131725.7dbee7aa@centurylink.net>
Date: Mon, 20 Nov 2017 23:40:53 +0100
In-Reply-To: <20171112131725.7dbee7aa@centurylink.net> (Eric Bavier's message
	of "Sun, 12 Nov 2017 13:17:25 -0600")
Message-ID: <87shd8y3nu.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Eric Bavier <ericbavier@centurylink.net>
Cc: 29271@debbugs.gnu.org, Chris Marusich <cmmarusich@gmail.com>, myglc2@gmail.com

Hello!

Eric Bavier <ericbavier@centurylink.net> skribis:

> On Sun, 12 Nov 2017 15:36:44 -0500
> Leo Famulari <leo@famulari.name> wrote:
>
>> On Sun, Nov 12, 2017 at 03:05:58AM -0800, Chris Marusich wrote:
>> > +@anchor{fallback-option}
>> >  @item --fallback
>> > -When substituting a pre-built binary fails, fall back to building
>> > -packages locally.
>> > +Attempt to build locally instead of issuing an error when substitutes
>> > +are enabled and a substitute is available, but the substitution attem=
pt
>> > +fails (@pxref{Substitution Failure}).=20=20
>>=20
>> I was able to read this smaller change. I think the new sentence is too
>> byzantine. I know what --fallback does but I found this sentence hard to
>> understand.
>
> Same here.

[...]

> IMHO, the original text is just fine, and succinctly conveys the
> origin of the option name. Perhaps just add the cross reference.

I agree, but I=E2=80=99m biased.  ;-)

Apart from that, the rest LGTM.  I have one minor request:

> +* Hydra::                           One particular source of substitutes.

I would call this =E2=80=9COfficial Substitute Server=E2=80=9D or something=
 like that,
and not mention Hydra (as a proper noun) since we=E2=80=99re not defining i=
t,
and since the server won=E2=80=99t run Hydra forever.

With these two changes, I think you can push.

Thanks for improving the manual!

Ludo=E2=80=99.