unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 33540@debbugs.gnu.org
Subject: [bug#33540] [PATCH 3/3] gnu: Add apertium.
Date: Sun, 02 Dec 2018 23:28:09 +0100	[thread overview]
Message-ID: <87sgzfk1hi.fsf@gnu.org> (raw)
In-Reply-To: <20181130071612.6268-3-arunisaac@systemreboot.net> (Arun Isaac's message of "Fri, 30 Nov 2018 12:46:12 +0530")

Arun Isaac <arunisaac@systemreboot.net> skribis:

> * gnu/packages/dictionaries.scm (apertium): New variable.

[...]

> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/apertium/apertium/releases/download/v"
> +             version "/apertium-" version ".tar.gz"))

Please use ‘git-fetch’ as well.

> +    (native-inputs
> +     `(("apertium-get"
> +        ,(origin
> +           (method git-fetch)
> +           (uri (git-reference
> +                 (url "https://github.com/apertium/apertium-get")
> +                 (commit "692d030e68008fc123089cf2446070fe8c6e3a3b")))
> +           (sha256
> +            (base32
> +             "0kgp68azvds7yjwfz57z8sa5094fyk5yr0qxzblrw7bisrrihnav"))))

Is there a Git submodule that would make this unnecessary?

Otherwise LGTM, thanks!

Ludo’.

  reply	other threads:[~2018-12-02 22:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-28 16:55 [bug#33540] [PATCH 0/3] Add apertium Arun Isaac
2018-11-30  0:22 ` swedebugia
2018-11-30  7:12   ` Arun Isaac
2018-11-30  7:16 ` [bug#33540] [PATCH 1/3] gnu: dictionaries: Use license prefix Arun Isaac
2018-11-30  7:16   ` [bug#33540] [PATCH 2/3] gnu: Add lttoolbox Arun Isaac
2018-12-02 22:26     ` Ludovic Courtès
2018-12-03  7:36       ` Arun Isaac
2018-12-03  9:36         ` Ludovic Courtès
2018-11-30  7:16   ` [bug#33540] [PATCH 3/3] gnu: Add apertium Arun Isaac
2018-12-02 22:28     ` Ludovic Courtès [this message]
2018-12-02 22:23   ` [bug#33540] [PATCH 1/3] gnu: dictionaries: Use license prefix Ludovic Courtès
2018-12-03 16:50 ` [bug#33540] [PATCH v2 0/3] Add lttoolbox, apertium Arun Isaac
2018-12-03 16:50   ` [bug#33540] [PATCH v2 1/3] gnu: dictionaries: Use license prefix Arun Isaac
2018-12-03 16:50   ` [bug#33540] [PATCH v2 2/3] gnu: Add lttoolbox Arun Isaac
2018-12-03 16:50   ` [bug#33540] [PATCH v2 3/3] gnu: Add apertium Arun Isaac
2018-12-04  8:36   ` [bug#33540] [PATCH v2 0/3] Add lttoolbox, apertium Ludovic Courtès
2018-12-04 18:41     ` bug#33540: " Arun Isaac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sgzfk1hi.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=33540@debbugs.gnu.org \
    --cc=arunisaac@systemreboot.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).