From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56757)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gTaS1-0003X7-RM
	for guix-patches@gnu.org; Sun, 02 Dec 2018 17:42:58 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gTaEY-0006Hw-OW
	for guix-patches@gnu.org; Sun, 02 Dec 2018 17:29:03 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:54174)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gTaEY-0006Hq-LS
	for guix-patches@gnu.org; Sun, 02 Dec 2018 17:29:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gTaEY-0006lB-F0
	for guix-patches@gnu.org; Sun, 02 Dec 2018 17:29:02 -0500
Subject: [bug#33540] [PATCH 3/3] gnu: Add apertium.
Resent-Message-ID: <handler.33540.B33540.154378969925927@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20181130071612.6268-1-arunisaac@systemreboot.net>
	<20181130071612.6268-3-arunisaac@systemreboot.net>
Date: Sun, 02 Dec 2018 23:28:09 +0100
In-Reply-To: <20181130071612.6268-3-arunisaac@systemreboot.net> (Arun Isaac's
	message of "Fri, 30 Nov 2018 12:46:12 +0530")
Message-ID: <87sgzfk1hi.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 33540@debbugs.gnu.org

Arun Isaac <arunisaac@systemreboot.net> skribis:

> * gnu/packages/dictionaries.scm (apertium): New variable.

[...]

> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/apertium/apertium/releases/download/v"
> +             version "/apertium-" version ".tar.gz"))

Please use =E2=80=98git-fetch=E2=80=99 as well.

> +    (native-inputs
> +     `(("apertium-get"
> +        ,(origin
> +           (method git-fetch)
> +           (uri (git-reference
> +                 (url "https://github.com/apertium/apertium-get")
> +                 (commit "692d030e68008fc123089cf2446070fe8c6e3a3b")))
> +           (sha256
> +            (base32
> +             "0kgp68azvds7yjwfz57z8sa5094fyk5yr0qxzblrw7bisrrihnav"))))

Is there a Git submodule that would make this unnecessary?

Otherwise LGTM, thanks!

Ludo=E2=80=99.