From: "Ludovic Courtès" <ludo@gnu.org>
To: Roel Janssen <roel@gnu.org>
Cc: 39013@debbugs.gnu.org
Subject: [bug#39013] [PATCH] gnu: Add abseil-cpp.
Date: Thu, 09 Jan 2020 22:53:11 +0100 [thread overview]
Message-ID: <87sgkos3eg.fsf@gnu.org> (raw)
In-Reply-To: <1f9fb8236e2a652ea4389c8d18b663307b275153.camel@gnu.org> (Roel Janssen's message of "Tue, 07 Jan 2020 16:07:21 +0100")
Hi Roel,
Roel Janssen <roel@gnu.org> skribis:
> There are two not-so-perfect things with the patch:
> 1. I had to use the latest Git commit because it adds bits to build
> shared libraries.
Sounds good to me.
> 2. I disabled the tests because it attempts to download "googletest".
> I tried modifying the build system to use "googletest" from Guix but
> that wasn't succesful.
There are packages such as ‘encfs’ where we simply unpack the source of
our ‘googletest’ package in the right place. Would what work here?
> From 06ed0284561463c087ec0f16f9c35fc7926f22df Mon Sep 17 00:00:00 2001
> From: Roel Janssen <roel@gnu.org>
> Date: Tue, 7 Jan 2020 16:02:28 +0100
> Subject: [PATCH] gnu: Add abseil-cpp.
>
> * gnu/packages/machine-learning.scm (abseil-cpp): New variable.
[...]
> + (description "Abseil is an open-source collection of C++ library code
s/an open-source/a/
> +designed to augment the C++ standard library. The Abseil library code is
> +collected from Google's own C++ code base, has been extensively tested and
> +used in production, and is the same code we depend on in our daily coding
> +lives.")
Who’s “we”? :-) Would be great if you could make that more factual.
Apart from that it LGTM.
Thanks,
Ludo’.
next prev parent reply other threads:[~2020-01-09 21:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 15:07 [bug#39013] [PATCH] gnu: Add abseil-cpp Roel Janssen
2020-01-09 21:53 ` Ludovic Courtès [this message]
2020-01-10 19:23 ` Roel Janssen
2020-01-15 20:53 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgkos3eg.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=39013@debbugs.gnu.org \
--cc=roel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).