From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:58450)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ipfkh-0001Gi-2D
 for guix-patches@gnu.org; Thu, 09 Jan 2020 16:54:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ipfkg-0005PG-0t
 for guix-patches@gnu.org; Thu, 09 Jan 2020 16:54:02 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:47218)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1ipfkf-0005O3-RM
 for guix-patches@gnu.org; Thu, 09 Jan 2020 16:54:01 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ipfkf-0003kP-Qn
 for guix-patches@gnu.org; Thu, 09 Jan 2020 16:54:01 -0500
Subject: [bug#39013] [PATCH] gnu: Add abseil-cpp.
Resent-Message-ID: <handler.39013.B39013.157860680014328@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <1f9fb8236e2a652ea4389c8d18b663307b275153.camel@gnu.org>
Date: Thu, 09 Jan 2020 22:53:11 +0100
In-Reply-To: <1f9fb8236e2a652ea4389c8d18b663307b275153.camel@gnu.org> (Roel
 Janssen's message of "Tue, 07 Jan 2020 16:07:21 +0100")
Message-ID: <87sgkos3eg.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Roel Janssen <roel@gnu.org>
Cc: 39013@debbugs.gnu.org

Hi Roel,

Roel Janssen <roel@gnu.org> skribis:

> There are two not-so-perfect things with the patch:
> 1. I had to use the latest Git commit because it adds bits to build
> shared libraries.

Sounds good to me.

> 2. I disabled the tests because it attempts to download "googletest".=20
> I tried modifying the build system to use "googletest" from Guix but
> that wasn't succesful.

There are packages such as =E2=80=98encfs=E2=80=99 where we simply unpack t=
he source of
our =E2=80=98googletest=E2=80=99 package in the right place.  Would what wo=
rk here?

> From 06ed0284561463c087ec0f16f9c35fc7926f22df Mon Sep 17 00:00:00 2001
> From: Roel Janssen <roel@gnu.org>
> Date: Tue, 7 Jan 2020 16:02:28 +0100
> Subject: [PATCH] gnu: Add abseil-cpp.
>
> * gnu/packages/machine-learning.scm (abseil-cpp): New variable.

[...]

> +      (description "Abseil is an open-source collection of C++ library c=
ode

s/an open-source/a/

> +designed to augment the C++ standard library.  The Abseil library code is
> +collected from Google's own C++ code base, has been extensively tested a=
nd
> +used in production, and is the same code we depend on in our daily coding
> +lives.")

Who=E2=80=99s =E2=80=9Cwe=E2=80=9D?  :-)  Would be great if you could make =
that more factual.

Apart from that it LGTM.

Thanks,
Ludo=E2=80=99.