From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: 43624@debbugs.gnu.org
Cc: marco.au.grassi98@protonmail.com, 43624-done@debbugs.gnu.org
Subject: [bug#43624] [PATCH]Add emacs-mood-line
Date: Sun, 27 Sep 2020 14:24:56 +0200 [thread overview]
Message-ID: <87sgb34dbb.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <4GvVAJeTFZKw5WgUEXXxi9kTcCkzvYdnmqSeiesdQvXl9JbUe8CUIQu1u7r4s18KesfVyPdp5fMzAs6ULbRwf53c2j5lsoH7tmTp6lt_4bw=@protonmail.com> (marco au.grassi's message of "Fri, 25 Sep 2020 18:10:29 +0000")
Hello,
"marco.au.grassi98--- via Guix-patches" via <guix-patches@gnu.org>
writes:
> Hello, i made a patch to add the mood-line emacs package.
Thank you.
> This is my first contribution, let me know if i did something wrong.
Welcome!
I made the changes detailed below and applied your patch.
> Subject: [PATCH] Add emacs-mood-line.
I changed the commit message to
gnu: Add emacs-mood-line.
* gnu/packages/emacs-xyz.scm (emacs-mood-line): New variable.
as it is standard practice in the repository. If you use Emacs (!) and
Yasnippets, typing "add" and <TAB> in an empty commit message should
fill the template above for you.
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://gitlab.com/jessieh/mood-line.git")
> + (commit version)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "0fh9j9fkgl433nykfzjnzap5labi4sdndfk1nv4f904ij69pmvxb"))))
I moved `origin' below `source' and the hash string on the same line as
`base32'. I also fixed indentation of the whole definition. Eventually,
I removed the ".git" suffix from the URI.
> + (build-system emacs-build-system)
> + (home-page "https://gitlab.com/jessieh/mood-line")
> + (synopsis "Minimal mode-line for Emacs")
> + (description "Mood-line is a minimal mode-line configuration that aims
> +to replicate some of the features of the
> +doom-modeline package.")
I added a reference to Emacs in the description, moved the text below
the `description' keyword (a nitpick of mine), and changed doom-modeline
to Doom modeline (nitpick about typography vs. Lisp naming practices).
> + (license license:gpl3+)))
I also added a copyright line for you in the file header. Please let me
know if I fumbled on one of its parts.
I also fixed the license, which is gpl2+ according to library's header
lines.
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2020-09-27 12:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 18:10 [bug#43624] [PATCH]Add emacs-mood-line marco.au.grassi98--- via Guix-patches via
2020-09-27 12:24 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgb34dbb.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=43624-done@debbugs.gnu.org \
--cc=43624@debbugs.gnu.org \
--cc=marco.au.grassi98@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).