From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id WIBDNOOEcF9xQwAA0tVLHw (envelope-from ) for ; Sun, 27 Sep 2020 12:26:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id WO4fMOOEcF95OwAAbx9fmQ (envelope-from ) for ; Sun, 27 Sep 2020 12:26:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3D9AD94042F for ; Sun, 27 Sep 2020 12:26:11 +0000 (UTC) Received: from localhost ([::1]:34838 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kMVkn-0006WM-F6 for larch@yhetil.org; Sun, 27 Sep 2020 08:26:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54328) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMVkg-0006W1-J9 for guix-patches@gnu.org; Sun, 27 Sep 2020 08:26:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37028) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kMVkg-0007bG-A2 for guix-patches@gnu.org; Sun, 27 Sep 2020 08:26:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kMVkg-00044D-6Z for guix-patches@gnu.org; Sun, 27 Sep 2020 08:26:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43624] [PATCH]Add emacs-mood-line Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 27 Sep 2020 12:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43624 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 43624@debbugs.gnu.org Cc: marco.au.grassi98@protonmail.com, 43624-done@debbugs.gnu.org X-Debbugs-Original-To: "marco.au.grassi98--- via Guix-patches" via Received: via spool by submit@debbugs.gnu.org id=B.160120951915581 (code B ref -1); Sun, 27 Sep 2020 12:26:02 +0000 Received: (at submit) by debbugs.gnu.org; 27 Sep 2020 12:25:19 +0000 Received: from localhost ([127.0.0.1]:48573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMVjy-00043D-NQ for submit@debbugs.gnu.org; Sun, 27 Sep 2020 08:25:19 -0400 Received: from lists.gnu.org ([209.51.188.17]:57700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kMVju-00042v-Ax for submit@debbugs.gnu.org; Sun, 27 Sep 2020 08:25:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54122) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMVju-0006On-5E for guix-patches@gnu.org; Sun, 27 Sep 2020 08:25:14 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:53569) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMVjr-0007Mx-F9 for guix-patches@gnu.org; Sun, 27 Sep 2020 08:25:13 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id C5AF0240004; Sun, 27 Sep 2020 12:25:05 +0000 (UTC) From: Nicolas Goaziou References: <4GvVAJeTFZKw5WgUEXXxi9kTcCkzvYdnmqSeiesdQvXl9JbUe8CUIQu1u7r4s18KesfVyPdp5fMzAs6ULbRwf53c2j5lsoH7tmTp6lt_4bw=@protonmail.com> Date: Sun, 27 Sep 2020 14:24:56 +0200 In-Reply-To: <4GvVAJeTFZKw5WgUEXXxi9kTcCkzvYdnmqSeiesdQvXl9JbUe8CUIQu1u7r4s18KesfVyPdp5fMzAs6ULbRwf53c2j5lsoH7tmTp6lt_4bw=@protonmail.com> (marco au.grassi's message of "Fri, 25 Sep 2020 18:10:29 +0000") Message-ID: <87sgb34dbb.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.193; envelope-from=mail@nicolasgoaziou.fr; helo=relay1-d.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/27 08:25:06 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -2.7 (--) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: iu6z1rt2ZD+u Hello, "marco.au.grassi98--- via Guix-patches" via writes: > Hello, i made a patch to add the mood-line emacs package. Thank you. > This is my first contribution, let me know if i did something wrong. Welcome! I made the changes detailed below and applied your patch. > Subject: [PATCH] Add emacs-mood-line. I changed the commit message to gnu: Add emacs-mood-line. * gnu/packages/emacs-xyz.scm (emacs-mood-line): New variable. as it is standard practice in the repository. If you use Emacs (!) and Yasnippets, typing "add" and in an empty commit message should fill the template above for you. > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://gitlab.com/jessieh/mood-line.git") > + (commit version))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0fh9j9fkgl433nykfzjnzap5labi4sdndfk1nv4f904ij69pmvxb")))) I moved `origin' below `source' and the hash string on the same line as `base32'. I also fixed indentation of the whole definition. Eventually, I removed the ".git" suffix from the URI. > + (build-system emacs-build-system) > + (home-page "https://gitlab.com/jessieh/mood-line") > + (synopsis "Minimal mode-line for Emacs") > + (description "Mood-line is a minimal mode-line configuration that aims > +to replicate some of the features of the > +doom-modeline package.") I added a reference to Emacs in the description, moved the text below the `description' keyword (a nitpick of mine), and changed doom-modeline to Doom modeline (nitpick about typography vs. Lisp naming practices). > + (license license:gpl3+))) I also added a copyright line for you in the file header. Please let me know if I fumbled on one of its parts. I also fixed the license, which is gpl2+ according to library's header lines. Regards, -- Nicolas Goaziou