* [bug#53660] [PATCH] services/sound: Add a udev extension for the pulseaudio service type.
@ 2022-01-31 14:54 Maxim Cournoyer
2022-02-01 19:25 ` Liliana Marie Prikler
0 siblings, 1 reply; 3+ messages in thread
From: Maxim Cournoyer @ 2022-01-31 14:54 UTC (permalink / raw)
To: 53660; +Cc: Maxim Cournoyer
PulseAudio provides udev rules used to adjust the configuration of certain
hardware (e.g., sound cards); ensure they get used.
* gnu/services/sound.scm (pulseaudio-service-type): Extend the
udev-service-type with the pulseaudio package.
---
gnu/services/sound.scm | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/gnu/services/sound.scm b/gnu/services/sound.scm
index 1217223a0c..7beca35ffe 100644
--- a/gnu/services/sound.scm
+++ b/gnu/services/sound.scm
@@ -159,7 +159,9 @@ (define pulseaudio-service-type
(extensions
(list (service-extension session-environment-service-type
pulseaudio-environment)
- (service-extension etc-service-type pulseaudio-etc)))
+ (service-extension etc-service-type pulseaudio-etc)
+ (service-extension udev-service-type (lambda _
+ (list pulseaudio)))))
(default-value (pulseaudio-configuration))
(description "Configure PulseAudio sound support.")))
--
2.34.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* [bug#53660] [PATCH] services/sound: Add a udev extension for the pulseaudio service type.
2022-01-31 14:54 [bug#53660] [PATCH] services/sound: Add a udev extension for the pulseaudio service type Maxim Cournoyer
@ 2022-02-01 19:25 ` Liliana Marie Prikler
2022-02-02 2:54 ` bug#53660: " Maxim Cournoyer
0 siblings, 1 reply; 3+ messages in thread
From: Liliana Marie Prikler @ 2022-02-01 19:25 UTC (permalink / raw)
To: Maxim Cournoyer, 53660
Am Montag, dem 31.01.2022 um 09:54 -0500 schrieb Maxim Cournoyer:
> PulseAudio provides udev rules used to adjust the configuration of
> certain
> hardware (e.g., sound cards); ensure they get used.
>
> * gnu/services/sound.scm (pulseaudio-service-type): Extend the
> udev-service-type with the pulseaudio package.
> ---
> gnu/services/sound.scm | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/services/sound.scm b/gnu/services/sound.scm
> index 1217223a0c..7beca35ffe 100644
> --- a/gnu/services/sound.scm
> +++ b/gnu/services/sound.scm
> @@ -159,7 +159,9 @@ (define pulseaudio-service-type
> (extensions
> (list (service-extension session-environment-service-type
> pulseaudio-environment)
> - (service-extension etc-service-type pulseaudio-etc)))
> + (service-extension etc-service-type pulseaudio-etc)
> + (service-extension udev-service-type (lambda _
> + (list
> pulseaudio)))))
You should use const, otherwise SGTM.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#53660: [PATCH] services/sound: Add a udev extension for the pulseaudio service type.
2022-02-01 19:25 ` Liliana Marie Prikler
@ 2022-02-02 2:54 ` Maxim Cournoyer
0 siblings, 0 replies; 3+ messages in thread
From: Maxim Cournoyer @ 2022-02-02 2:54 UTC (permalink / raw)
To: Liliana Marie Prikler; +Cc: 53660-done
Hello,
Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
> Am Montag, dem 31.01.2022 um 09:54 -0500 schrieb Maxim Cournoyer:
>> PulseAudio provides udev rules used to adjust the configuration of
>> certain
>> hardware (e.g., sound cards); ensure they get used.
>>
>> * gnu/services/sound.scm (pulseaudio-service-type): Extend the
>> udev-service-type with the pulseaudio package.
>> ---
>> gnu/services/sound.scm | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/services/sound.scm b/gnu/services/sound.scm
>> index 1217223a0c..7beca35ffe 100644
>> --- a/gnu/services/sound.scm
>> +++ b/gnu/services/sound.scm
>> @@ -159,7 +159,9 @@ (define pulseaudio-service-type
>> (extensions
>> (list (service-extension session-environment-service-type
>> pulseaudio-environment)
>> - (service-extension etc-service-type pulseaudio-etc)))
>> + (service-extension etc-service-type pulseaudio-etc)
>> + (service-extension udev-service-type (lambda _
>> + (list
>> pulseaudio)))))
> You should use const, otherwise SGTM.
Good catch! Adjusted and pushed as
fff4daa5c2bfbf42c7ad2519f500bd254ce880a8.
Thank you,
Maxim
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-02 4:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-31 14:54 [bug#53660] [PATCH] services/sound: Add a udev extension for the pulseaudio service type Maxim Cournoyer
2022-02-01 19:25 ` Liliana Marie Prikler
2022-02-02 2:54 ` bug#53660: " Maxim Cournoyer
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).