unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: guix-patches--- via <guix-patches@gnu.org>
To: 58569@debbugs.gnu.org
Subject: [bug#58569] [PATCH] gnu packages gnome-console: Remove nautilus extension
Date: Sun, 16 Oct 2022 19:34:21 +0200	[thread overview]
Message-ID: <87sfjnad0i.fsf@disroot.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 924 bytes --]


Hi,

this patch removes the gnome-console nautilus extension as it crashes nautilus
(at least on my machine). In my opinion it is safe to remove it, as this
feature is implemented directly into nautilus-43 and the original code is
purged from the gnome-console repo. (see
https://gitlab.gnome.org/GNOME/nautilus/-/merge_requests/911 and
https://gitlab.gnome.org/GNOME/console/-/commit/c4bd2312f4b432a33810a8dcdf3cadabae5169d7)

This sadly means, that in nautilus-42 there will be no "Open in Console", but
the issue is on some code that is already deprecated in the Console repo. (I
have studied gdb info and it appears that kgx_nautilus_get_background_items()
returns a GList* that is { .next = NULL, .prev = NULL, .data = NULL } but
nautilus does only perform a check that GList* is NULL, otherwise it expects a
valid list)

I can maybe supply a patch to gnome-console, but I don't see a reason to.

Kind regards,

Maya


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-packages-gnome-console-Remove-nautilus-extension.patch --]
[-- Type: text/x-patch, Size: 722 bytes --]

---
 gnu/packages/gnome.scm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index fbaef9eb6e..c71894bcb9 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -5445,8 +5445,7 @@ (define-public gnome-console
     (build-system meson-build-system)
     (arguments
      (list #:glib-or-gtk? #t
-           #:configure-flags #~(list "-Dtests=true"
-                                     "-Dnautilus=enabled")
+           #:configure-flags #~(list "-Dtests=true")
            #:phases #~(modify-phases %standard-phases
                         (add-after 'unpack 'patch-nautilus-extension-path
                           (lambda _
-- 
2.37.3


             reply	other threads:[~2022-10-16 17:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-16 17:34 guix-patches--- via [this message]
2022-10-17  8:18 ` [bug#58569] [PATCH] gnu packages gnome-console: Remove nautilus extension Liliana Marie Prikler
2022-10-17 16:20   ` guix-patches--- via
2022-10-18  6:19     ` Liliana Marie Prikler
2022-10-18 21:48       ` Dominic Martinez via Guix-patches via
2022-10-20 19:58         ` guix-patches--- via
2022-10-21  6:09           ` Liliana Marie Prikler
2022-10-24 21:54             ` guix-patches--- via
2022-10-25  5:59               ` Liliana Marie Prikler
2022-10-24 21:50         ` guix-patches--- via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfjnad0i.fsf@disroot.org \
    --to=guix-patches@gnu.org \
    --cc=58569@debbugs.gnu.org \
    --cc=maya.tomasek@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).