From: Janneke Nieuwenhuizen <janneke@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: alezost@gmail.com, 43236-done@debbugs.gnu.org
Subject: bug#43236: [PATCH emacs-guix] elisp: guix-set-emacs-environment: Also update Emacs' path.
Date: Mon, 16 Jan 2023 22:33:05 +0100 [thread overview]
Message-ID: <87sfgaxizy.fsf@gnu.org> (raw)
In-Reply-To: <875yd65pbz.fsf@gmail.com> (Maxim Cournoyer's message of "Mon, 16 Jan 2023 13:03:44 -0500")
Maxim Cournoyer writes:
Hi Maxim,
> "Jan (janneke) Nieuwenhuizen" <janneke@gnu.org> writes:
>
>> This helps Geiser find the correct (environment's) Guile.
>> -;; Copyright © 2018 Jan (janneke) Nieuwenhuizen <janneke@gnu.org>
>> +;; Copyright © 2018,2020 Jan (janneke) Nieuwenhuizen <janneke@gnu.org>
>
> There's no use for a copyright line here as the change is not
> substantial enough (< 10 lines).
Ah...I guess I figured that we need copyright years to be updated in all
years the program is "released". Oh well...
>> + (when (equalp variable "PATH")
>> + (setq exec-path (split-string value ":")))))))
>
> That's still useful with Emacs 28, right? If you can confirm it, LGTM.
It's still useful...but also...I found this has already been installed
as
commit d246b2c443bbb9d49575b63bb78c14699c4448cf
elisp/misc: Update Emacs path if needed
and
41fba4eec845e050be92bfe76c0f7980bbe821bd
Fix the previous commit
Sorry for the noise...Closing.
Greetings,
Janneke
--
Janneke Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com
next prev parent reply other threads:[~2023-01-16 21:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-06 8:46 [bug#43236] [PATCH emacs-guix] elisp: guix-set-emacs-environment: Also update Emacs' path Jan (janneke) Nieuwenhuizen
2023-01-16 18:03 ` Maxim Cournoyer
2023-01-16 21:33 ` Janneke Nieuwenhuizen [this message]
2023-01-17 1:46 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfgaxizy.fsf@gnu.org \
--to=janneke@gnu.org \
--cc=43236-done@debbugs.gnu.org \
--cc=alezost@gmail.com \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).