From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Jan (janneke) Nieuwenhuizen" <janneke@gnu.org>
Cc: alezost@gmail.com, 43236@debbugs.gnu.org
Subject: [bug#43236] [PATCH emacs-guix] elisp: guix-set-emacs-environment: Also update Emacs' path.
Date: Mon, 16 Jan 2023 13:03:44 -0500 [thread overview]
Message-ID: <875yd65pbz.fsf@gmail.com> (raw)
In-Reply-To: <20200906084646.28115-1-janneke@gnu.org> (Jan Nieuwenhuizen's message of "Sun, 6 Sep 2020 10:46:46 +0200")
Hi Janneke,
"Jan (janneke) Nieuwenhuizen" <janneke@gnu.org> writes:
> This helps Geiser find the correct (environment's) Guile.
>
> * elisp/guix-misc.el (guix-set-emacs-environment): Set "exec-path"
> when setting "PATH" variable.
> ---
> elisp/guix-misc.el | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/elisp/guix-misc.el b/elisp/guix-misc.el
> index 6f79fe6..7e9c068 100644
> --- a/elisp/guix-misc.el
> +++ b/elisp/guix-misc.el
> @@ -1,7 +1,7 @@
> ;;; guix-misc.el --- Miscellaneous definitions -*- lexical-binding: t -*-
>
> ;; Copyright © 2014–2018 Alex Kost <alezost@gmail.com>
> -;; Copyright © 2018 Jan (janneke) Nieuwenhuizen <janneke@gnu.org>
> +;; Copyright © 2018,2020 Jan (janneke) Nieuwenhuizen <janneke@gnu.org>
There's no use for a copyright line here as the change is not
substantial enough (< 10 lines).
> ;; This file is part of Emacs-Guix.
>
> @@ -242,7 +242,9 @@ If PROFILE is nil, use `guix-current-profile'."
> (value (if (and separator current-value)
> (concat path separator current-value)
> path)))
> - (setenv variable value)))))
> + (setenv variable value)
> + (when (equalp variable "PATH")
> + (setq exec-path (split-string value ":")))))))
That's still useful with Emacs 28, right? If you can confirm it, LGTM.
--
Thanks,
Maxim
next prev parent reply other threads:[~2023-01-16 18:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-06 8:46 [bug#43236] [PATCH emacs-guix] elisp: guix-set-emacs-environment: Also update Emacs' path Jan (janneke) Nieuwenhuizen
2023-01-16 18:03 ` Maxim Cournoyer [this message]
2023-01-16 21:33 ` bug#43236: " Janneke Nieuwenhuizen
2023-01-17 1:46 ` [bug#43236] " Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875yd65pbz.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=43236@debbugs.gnu.org \
--cc=alezost@gmail.com \
--cc=janneke@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).