From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Danny O'Brien" <danny@fil.org>
Cc: "Tobias Geerinckx-Rice" <me@tobias.gr>,
"Ludovic Courtès" <ludo@gnu.org>,
61263-done@debbugs.gnu.org, 61270-done@debbugs.gnu.org
Subject: bug#61263: bug#61270: [PATCH] gnu: dbacl: Fix failing check phase.
Date: Tue, 21 Mar 2023 22:13:21 -0400 [thread overview]
Message-ID: <87sfdxildq.fsf_-_@gmail.com> (raw)
In-Reply-To: <ZARDtUMqgtSR26h7@workboat.fil.org> (Danny O'Brien's message of "Sat, 4 Mar 2023 23:24:37 -0800")
Hi,
"Danny O'Brien" <danny@fil.org> writes:
> On Sat, Mar 04, 2023 at 05:37:27PM +0100, Ludovic Courtès wrote:
>> Hi Danny,
>>
>> "Danny O'Brien" <danny@spesh.com> skribis:
>>
>> > Yep, that was all due to `guix style` — the instructions say to run it, but
>> > that may be different if it's just tweaking an existing hand-crafted
>> > package description. I'll re-submit.
>>
>> Did you get a chance to look into it? We’re close to the finish line!
>>
>> TIA,
>> Ludo’.
>
> Let's try this:
>
[...]
> diff --git a/gnu/packages/textutils.scm b/gnu/packages/textutils.scm
> index e5d3a0efc0..1092f1860b 100644
> --- a/gnu/packages/textutils.scm
> +++ b/gnu/packages/textutils.scm
> @@ -25,6 +25,7 @@
> ;;; Copyright © 2021 Felix Gruber <felgru@posteo.net>
> ;;; Copyright © 2021 Bonface Munyoki Kilyungi <me@bonfacemunyoki.com>
> ;;; Copyright © 2022 Gabriel Wicki <gabriel@erlikon.ch>
> +;;; Copyright © 2022 Danny O'Brien <danny@spesh.com>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -711,7 +712,7 @@ (define-public dbacl
> "dbacl-" version ".tar.gz"))
> (sha256
> (base32 "1gas0112wqjvwn9qg3hxnawk7h3prr0w9b2h68f3p1ifd1kzn3gz"))
> - (patches (search-patches "dbacl-include-locale.h.patch"))))
> + (patches (search-patches "dbacl-include-locale.h.patch" "dbacl-icheck-multiple-definitions.patch"))))
> (build-system gnu-build-system)
> (arguments
> `(#:make-flags
I've installed this change, but dropped your copyright line, as changes
smaller than 10-15 lines of new code are not subjected to copyright.
--
Thanks,
Maxim
prev parent reply other threads:[~2023-03-22 2:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-04 5:08 [bug#61263] [PATCH] gnu: dbacl: Fix failing check phase danny
2023-02-04 10:07 ` Tobias Geerinckx-Rice via Guix-patches via
2023-02-05 4:53 ` Danny O'Brien
2023-03-04 16:37 ` [bug#61263] bug#61270: " Ludovic Courtès
2023-03-05 7:24 ` [bug#61270] " Danny O'Brien via Guix-patches via
2023-03-22 2:13 ` Maxim Cournoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfdxildq.fsf_-_@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=61263-done@debbugs.gnu.org \
--cc=61270-done@debbugs.gnu.org \
--cc=danny@fil.org \
--cc=ludo@gnu.org \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).